Data vetoes on injections in PyGRB #4979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
titodalcanton
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is (hopefully!) the last one of the series started in PR #4929. It fills in the method
apply_vetoes_to_found_injsto complete the vetoing via VDFs in PyGRB. A few syntax improvements were carried out onpygrb_postprocessing_utils.py.Standard information about the request
This is a: the final part of a new feature enabling veto definer file usage in PyGRB.
This change affects: PyGRB
This change changes: result presentation / plotting and scientific output.
Motivation
Now that the workflow generator passes the veto definer file to the jobs where needed, its usage in the PyGRB results scripts is possible and this PR should complete it.
Testing performed
The totality of the changes that were broken down in multiple PRs was tested on GRB 170817A data by producing a full results webpage (see here).