Move to igwn-ligolw #5019
Draft
Move to igwn-ligolw #5019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
titodalcanton
added
on hold
dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move from python-ligo-lw to the recently released and more modern igwn-ligolw.
Standard information about the request
This is a depencency change.
This change should have no impact on any functionality or result.
This change will drop the dependency on python-ligo-lw and introduce a depencency on igwn-ligolw.
Motivation
igwn-ligolw is more actively maintained and supports modern Python versions and more architectures than python-ligo-lw.
Contents
Mainly replacing imports, but the transition from python-ligo-lw 1.8.3 to igwn-ligolw 2.0.0 has the side effect of introducing a few breaking changes which never made it to a python-ligo-lw release yet, so those are handled as well. We can also further simplify
tox.ini, consistently with #4857.Links to any issues or associated PRs
This is essentially a counterpart to #4999. Improves #4857.
Testing performed
Ran
toxand a few of the tests manually on a local machine, but I am relying on the CI for now.Additional notes
I am not sure I want to push this to production codes yet, at least not before more significant testing is done with workflows and GraceDB interactions. In particular, I think we should create a release branch for PyGRB's O4a analysis before merging this (@pannarale). So I am applying a "on hold" label.