Merged
Conversation
tdent
requested review from
GarethCabournDavies,
ahnitz,
rahuldhurkunde and
spxiwh
GarethCabournDavies
approved these changes
Feb 6, 2025
Contributor
GarethCabournDavies
left a comment
GarethCabournDavies
left a comment
There was a problem hiding this comment.
Thanks for getting to this! A couple of comments, but I think this is close to being right.
Contributor
Author
|
So .. atm I have this are all these different forms really needed ? |
Contributor
Author
|
Seems I was able to do without |
GarethCabournDavies
approved these changes
Feb 10, 2025
Contributor
GarethCabournDavies
left a comment
GarethCabournDavies
left a comment
There was a problem hiding this comment.
LGTM - there are a couple of places which might be nice to get new features, but those aren't important straight away
Merged
tdent
added
the
v23_release_branch
spxiwh
pushed a commit
to spxiwh/pycbc
that referenced
this pull request
Feb 18, 2025
* added plot script * cleanups * remove now unused bits * Generalize fit plotting * rename script
Merged
spxiwh
pushed a commit
to spxiwh/pycbc
that referenced
this pull request
Feb 27, 2025
* added plot script * cleanups * remove now unused bits * Generalize fit plotting * rename script
spxiwh
pushed a commit
to spxiwh/pycbc
that referenced
this pull request
Feb 27, 2025
* added plot script * cleanups * remove now unused bits * Generalize fit plotting * rename script
spxiwh
added a commit
that referenced
this pull request
Feb 27, 2025
* Merge part of 4997 to avoid failure * Bump to v2310 * Compressed waveforms bank workflow (#4969) * Add compressed waveforms to bank workflow * Allolw plotting script to use any bank conversion parameter * Some fixes to allow the joined bank to be plotted * Use inference's parameter labels: they are available and mostly good * Add mismatch to plotting, make some tweaks * some tidying * thinko * Try to make the CI workflow run * Fix do-not-compress default * Use different examples in compress bank workflow * Proper name for the github workflow * Thinko * python shebang in compression workflow script * minor edits * move to readily-available waveform * TRy IMRPhenomD instead * revert change to workflow.core * Warn for KeyError in get_decompressed_waveform * Fix issue with if get_decompressed_waveform raised a ValueError * Combined plotifar (#5034) * added plot script * cleanups * remove now unused bits * Generalize fit plotting * rename script * Added page_farstat in summary (#5052) * Fix release naming * Stat correction patch (#5061) * Limit number of stage output jobs * Reorganize FAR/stat plots on summary page (#5061) * Get the dq files into a nice layout (#5064) * Sphinx version CI fix (#5060) * Update pycbc_page_fars_vs_stat (#5067) --------- Co-authored-by: Gareth S Cabourn Davies <gareth.cabourndavies@ligo.org> Co-authored-by: Thomas Dent <thomas.dent@usc.es> Co-authored-by: Rahul Dhurkunde <rahul.dhurkunde@ldas-pcdev6.ligo.caltech.edu>
GarethCabournDavies
removed
the
v23_release_branch
khunsang
pushed a commit
to khunsang/pycbc
that referenced
this pull request
May 23, 2025
* added plot script * cleanups * remove now unused bits * Generalize fit plotting * rename script
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #5006
Standard information about the request
This is a: new feature
This change affects: the offline search
This change changes: result presentation / plotting
This change: follows style guidelines (See e.g. PEP8), has been proposed using the contribution guidelines
Motivation
See #5006
Contents
Add a plotting script
Links to any issues or associated PRs
#5006 (again)
Testing performed
It produces a plot given exclude_zerolag files from a recent run with singles