Filter recipients settings to prevent NPE (RedHatInsights#2311)

gwenneg · Nov 6, 2023 · 2e2ff1a · 2e2ff1a
1 parent 05fc793
commit 2e2ff1a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/...ain/java/com/redhat/cloud/notifications/connector/email/EmailCloudEventDataExtractor.java b/...ain/java/com/redhat/cloud/notifications/connector/email/EmailCloudEventDataExtractor.java
@@ -35,6 +35,7 @@ public void extract(final Exchange exchange, final JsonObject cloudEventData) {
             .toList();
 
         final Set<String> emails = recipientSettings.stream()
+                .filter(settings -> settings.getEmails() != null)
                 .flatMap(settings -> settings.getEmails().stream())
                 .collect(toSet());
 

diff --git a/...java/com/redhat/cloud/notifications/connector/email/EmailCloudEventDataExtractorTest.java b/...java/com/redhat/cloud/notifications/connector/email/EmailCloudEventDataExtractorTest.java
@@ -9,7 +9,6 @@
 import org.junit.jupiter.api.Test;
 
 import java.util.ArrayList;
-import java.util.Collections;
 import java.util.List;
 import java.util.Set;
 import java.util.UUID;
@@ -40,7 +39,7 @@ void testExtract() {
             true,
             UUID.randomUUID(),
             users,
-            Collections.emptySet()
+            null
         );
 
         final Set<String> users2 = Set.of("d", "e", "f");