Fix some typos #392
Merged
Fix some typos #392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbynek
commented
Mar 3, 2025
| @@ -47,7 +47,7 @@ Use the files generated by these scripts as a starting point for building your o | |||
| | ------------------------ | ---------- | | |||
| | -[no]overwriteFiles | Overwrite any existing files. (defaults to OFF) | |||
| | -[no]ignoreExistingFiles | Ignore any existing files; do not overwrite. (defaults to OFF) | |||
| | -templates | Specifies the template(s) to use (comma separeted). Defaults to 'sample,ant,eclipse,readme' | |||
| | -templates | Specifies the template(s) to use (comma separated). Defaults to 'sample,ant,eclipse,readme' | |||
There was a problem hiding this comment.
Comes from https://github.com/gwtproject/gwt/blob/78215ac9bd69a725375e5b3a36b83ed8f58ee5ad/user/src/com/google/gwt/user/tools/WebAppCreator.java#L400 , but maybe OK to fix here and not in the deprecated Java class?
There was a problem hiding this comment.
We don't generate the docs at this time, so changing it here first seems fine to me.
niloc132
previously approved these changes
Mar 4, 2025
niloc132
approved these changes
Apr 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found (and mostly auto-corrected) using https://github.com/crate-ci/typos