Fix compilation errors and restore logic after SDK 35/36 merge#19
Conversation
This commit resolves over 100 compilation and resource errors in the GKUIClock project that occurred after a large merge with the upstream repository. Key changes: - Fixed syntax errors and misplaced fields in `PreferencesDefaultValues.java`. - Restored missing methods in `SettingsDAO`, `Utils`, `ThemeUtils`, and `PermissionUtils` that were dropped during the merge but are required by existing UI and provider logic. - Re-implemented legacy `DialogFragment` classes (`VibrationPattern`, `VibrationStartDelay`, `AlarmMissedRepeatLimit`, `SpinnerTimePicker`) and created their associated XML layout resources. - Aligned `Alarm` and `AlarmInstance` call sites with the new instance-method based API. - Fixed `BuildConfig` symbol errors by adding missing fields to `app/build.gradle`. - Corrected inheritance for `DeskClock` (now extends `BaseActivity`) to fix `instanceof` compatibility. - Resolved duplicate string resource errors in `strings.xml`. - Disabled Room schema export for `HolidayDatabase` to suppress warnings. Verified with a successful `./gradlew assembleDebug` build. Co-authored-by: gx-bangsong <146644201+gx-bangsong@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This PR resolves over 100 compilation and resource errors in the GKUIClock project that occurred after a large merge with the upstream repository.
Key changes:
PreferencesDefaultValues.java.SettingsDAO,Utils,ThemeUtils, andPermissionUtilsthat were dropped during the merge but are required by existing UI and provider logic.DialogFragmentclasses (VibrationPattern,VibrationStartDelay,AlarmMissedRepeatLimit,SpinnerTimePicker) and created their associated XML layout resources.AlarmandAlarmInstancecall sites with the new instance-method based API.BuildConfigsymbol errors by adding missing fields toapp/build.gradle.DeskClock(now extendsBaseActivity) to fixinstanceofcompatibility.strings.xml.HolidayDatabaseto suppress warnings.Verified with a successful
./gradlew assembleDebugbuild.PR created automatically by Jules for task 9553958418776236841 started by @gx-bangsong