Skip to content

Fix ClassCastExceptions and align XML tags with refactored packages#25

Merged
gx-bangsong merged 1 commit intomainfrom
fix-class-cast-exceptions-align-xml-tags-10505217594634629648
Mar 29, 2026
Merged

Fix ClassCastExceptions and align XML tags with refactored packages#25
gx-bangsong merged 1 commit intomainfrom
fix-class-cast-exceptions-align-xml-tags-10505217594634629648

Conversation

@gx-bangsong
Copy link
Copy Markdown
Owner

This PR resolves multiple ClassCastException crashes caused by package refactoring and type mismatches between Java code and XML layouts.

Key changes:

  • Aligned TextTime package in alarm_time_expanded.xml with the refactored com.best.deskclock.widget package.
  • Updated key_shake_intensity and key_external_audio_device_volume in settings_alarm.xml to use CustomSliderPreference as expected by AlarmSettingsFragment.
  • Renamed key_bluetooth_volume to key_external_audio_device_volume in XML to match the constant used in Java.
  • Standardized all CustomSeekbarPreference usages in res/xml to the com.best.deskclock.settings.custompreference package.
  • Removed duplicate TextTime and CustomSeekbarPreference classes from legacy packages.
  • Updated Java fragments to import CustomSeekbarPreference from the correct package.
  • Verified successful compilation with ./gradlew compileDebugJavaWithJavac.

PR created automatically by Jules for task 10505217594634629648 started by @gx-bangsong

- Updated TextTime tags in alarm_time_expanded.xml to com.best.deskclock.widget.TextTime.
- Updated CustomSeekbarPreference to CustomSliderPreference for shake intensity and external audio volume in settings_alarm.xml.
- Renamed key_bluetooth_volume to key_external_audio_device_volume in XML to match Java constants.
- Swept all res/xml files to use the com.best.deskclock.settings.custompreference package for CustomSeekbarPreference.
- Removed redundant/duplicate CustomSeekbarPreference and TextTime classes from old packages.
- Updated Java fragments to import CustomSeekbarPreference from the new package.

Co-authored-by: gx-bangsong <146644201+gx-bangsong@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@gx-bangsong gx-bangsong merged commit 0aee3ab into main Mar 29, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant