Fix ClassCastExceptions and align XML tags with refactored packages#25
Conversation
- Updated TextTime tags in alarm_time_expanded.xml to com.best.deskclock.widget.TextTime. - Updated CustomSeekbarPreference to CustomSliderPreference for shake intensity and external audio volume in settings_alarm.xml. - Renamed key_bluetooth_volume to key_external_audio_device_volume in XML to match Java constants. - Swept all res/xml files to use the com.best.deskclock.settings.custompreference package for CustomSeekbarPreference. - Removed redundant/duplicate CustomSeekbarPreference and TextTime classes from old packages. - Updated Java fragments to import CustomSeekbarPreference from the new package. Co-authored-by: gx-bangsong <146644201+gx-bangsong@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This PR resolves multiple
ClassCastExceptioncrashes caused by package refactoring and type mismatches between Java code and XML layouts.Key changes:
TextTimepackage inalarm_time_expanded.xmlwith the refactoredcom.best.deskclock.widgetpackage.key_shake_intensityandkey_external_audio_device_volumeinsettings_alarm.xmlto useCustomSliderPreferenceas expected byAlarmSettingsFragment.key_bluetooth_volumetokey_external_audio_device_volumein XML to match the constant used in Java.CustomSeekbarPreferenceusages in res/xml to thecom.best.deskclock.settings.custompreferencepackage.TextTimeandCustomSeekbarPreferenceclasses from legacy packages.CustomSeekbarPreferencefrom the correct package../gradlew compileDebugJavaWithJavac.PR created automatically by Jules for task 10505217594634629648 started by @gx-bangsong