chore: upgrade to upstream 0.3.1 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
joelluijmes
commented
Jan 22, 2024
joelluijmes
commented
- Adds support for Mongo 6
- Part of gynzy/gynzy-backend-nest#1717
It seems there are some issues with the latest version of @babel/traverse, resulting in an OOM exception.
Calling fetchSockets() and then broadcasting to a remote socket with an
acknowledgement would fail in version < 4.7.3.
```js
const sockets = await io.fetchSockets();
const result = await sockets[0].emitWithAck("ping");
// result was always null regardless of the response of the client
```
Related: socketio/socket.io@df8e70f
forEach() was deprecated in [1]. [1]: mongodb/node-mongodb-native@8d76a71
|
please merge upstream change to |
|
okay disregard the above. |
genisd
approved these changes
Jan 23, 2024
This test seems to be flaky. We don't get it to pass on our CI, and upstream it also seems to be flaky. We are not hitting this codepath in our usecase, so we are confident in disabling this test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.