Add more careful norm_text check

This makes sure it's not none before checking if it can be stripped

gilda/term.py

@@ -52,8 +52,8 @@ def __init__(self, norm_text, text, db, id, entry_name, status, source,
                  organism=None, source_db=None, source_id=None):
         if not text:
             raise ValueError('Text for Term cannot be empty')
-        if not norm_text.strip():
-            raise ValueError('Normalized text for Term cannot be empty')
+        if not norm_text or not norm_text.strip():
+            raise ValueError('Normalized text for Term cannot be None nor empty')
         self.norm_text = norm_text
         self.text = text
         self.db = db

gilda/tests/test_term.py

@@ -1,32 +1,97 @@
+import pytest
+
 from gilda.term import Term, get_identifiers_url
 
 
+def test_invalid():
+    with pytest.raises(ValueError):
+        Term(
+            None,
+            "Mitochondria",
+            "GO",
+            "GO:0005739",
+            "mitochondrion",
+            "synonym",
+            "mesh",
+            None,
+            "MESH",
+            "D008928",
+        )
+
+    with pytest.raises(ValueError):
+        Term(
+            "",
+            "Mitochondria",
+            "GO",
+            "GO:0005739",
+            "mitochondrion",
+            "synonym",
+            "mesh",
+            None,
+            "MESH",
+            "D008928",
+        )
+
+    with pytest.raises(ValueError):
+        Term(
+            "   ",
+            "Mitochondria",
+            "GO",
+            "GO:0005739",
+            "mitochondrion",
+            "synonym",
+            "mesh",
+            None,
+            "MESH",
+            "D008928",
+        )
+
+
 def test_standalone_get_url():
-    assert get_identifiers_url('UP', 'P12345') == \
-        'https://identifiers.org/uniprot:P12345'
-    assert get_identifiers_url('HGNC', '12345') == \
-        'https://identifiers.org/hgnc:12345'
-    assert get_identifiers_url('CHEBI', 'CHEBI:12345') == \
-        'https://identifiers.org/CHEBI:12345'
+    assert (
+        get_identifiers_url("UP", "P12345") == "https://identifiers.org/uniprot:P12345"
+    )
+    assert get_identifiers_url("HGNC", "12345") == "https://identifiers.org/hgnc:12345"
+    assert (
+        get_identifiers_url("CHEBI", "CHEBI:12345")
+        == "https://identifiers.org/CHEBI:12345"
+    )
 
 
 def test_term_get_url():
-    term = Term(db='CHEBI', id='CHEBI:12345', entry_name='X',
-                norm_text='x', text='X', source='test', status='name')
-    assert term.get_curie() == \
-           'CHEBI:12345'
-    assert term.get_idenfiers_url() == \
-        'https://identifiers.org/CHEBI:12345'
+    term = Term(
+        db="CHEBI",
+        id="CHEBI:12345",
+        entry_name="X",
+        norm_text="x",
+        text="X",
+        source="test",
+        status="name",
+    )
+    assert term.get_curie() == "CHEBI:12345"
+    assert term.get_idenfiers_url() == "https://identifiers.org/CHEBI:12345"
     assert term.get_groundings() == {(term.db, term.id)}
     assert term.get_namespaces() == {term.db}
 
 
 def test_term_source_db_id():
-    term = Term('mitochondria', 'Mitochondria', 'GO', 'GO:0005739',
-                'mitochondrion', 'synonym', 'mesh', None, 'MESH', 'D008928')
-    assert term.source_db == 'MESH'
-    assert term.source_id == 'D008928'
-    assert term.get_groundings() == {(term.db, term.id),
-                                     (term.source_db, term.source_id)}
+    term = Term(
+        "mitochondria",
+        "Mitochondria",
+        "GO",
+        "GO:0005739",
+        "mitochondrion",
+        "synonym",
+        "mesh",
+        None,
+        "MESH",
+        "D008928",
+    )
+    assert term.source_db == "MESH"
+    assert term.source_id == "D008928"
+    assert term.get_groundings() == {
+        (term.db, term.id),
+        (term.source_db, term.source_id),
+    }
 
     assert term.get_namespaces() == {term.db, term.source_db}