CML tools guestos version + script polishing#136
Merged
Conversation
jwsbck
force-pushed
the
cml_tools_guestos_version
branch
from
a2c45bf to
b44a667
Compare
Member
|
For the AI-assisted commit, can you specify the model you used as stated in https://docs.kernel.org/process/coding-assistants.html#attribution, e.g. "Assisted-by: Claude:claude-opus-4-7" |
When generating a guestos using cml_build_guestos the version always defaults to 1. Allow setting the version using a --version parameter. Signed-off-by: Johannes Wiesböck <johannes.wiesboeck@aisec.fraunhofer.de>
- Add set -euo pipefail to all four scripts
- Use #!/usr/bin/env bash for portability
- Fix SC1097 bug: PROTO_FILE== -> PROTO_FILE=
- Fix SC2162: add -r to read invocations
- Fix SC2086: quote all variable expansions
- Fix SC2034: remove unused variables in gen_guestos.sh
- Fix set -u hazards: use ${1:-} where $1 may be unset,
fix [[ -d "WORKDIR" ]] -> [[ -d "${WORKDIR}" ]] literal-string bug
- Add DEBUG="${DEBUG:-}" at top of cml_build_guestos.sh
- Default GYROIDOS_VERSION to 1 in gen_guestos.sh for backward compat
- Add local declarations for function variables
Signed-off-by: Johannes Wiesböck <johannes.wiesboeck@aisec.fraunhofer.de>
Assisted-by: Claude:claude-sonnet-4-6
- Use #!/usr/bin/env bash for portability
- Add set -euo pipefail to all executable scripts
- Fix SC2086: quote all variable expansions
- Fix SC2071: use (( $# > 1 )) instead of [[ $# > 1 ]]
- Fix SC2068: pass "$@" to load_parameters
- Fix SC2046/SC2164: cd "$(dirname "$0")" || exit
- Fix SC1090: add # shellcheck source=/dev/null for runtime sources
- Fix SC2329: suppress unused cleanup in sec_platform_keys.sh
- Convert PASS_IN/PASS_OUT from strings to arrays for correct
optional-arg expansion in openssl calls
- Initialize DO_PLATFORM_KEYS and ADDITIONAL_DB_KEY with ${VAR:-}
for set -u safety
- Fix SC2086: convert cert_src to array
Signed-off-by: Johannes Wiesböck <johannes.wiesboeck@aisec.fraunhofer.de>
Assisted-by: Claude:claude-sonnet-4-6
Using realpath + BASH_SOURCE. Signed-off-by: Johannes Wiesböck <johannes.wiesboeck@aisec.fraunhofer.de>
jwsbck
force-pushed
the
cml_tools_guestos_version
branch
2 times, most recently
from
c36a4d4 to
4764c9f
Compare
aevykk
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.