Fix warning -Wparentheses

Fix warning: comparisons like 'X<=Y<=Z' do not have their mathematical meaning [-Wparentheses] See merge request gysela-developpers/gyselalibxx!455 --------------------------------------------
gyselax · Apr 10, 2024 · 044df67 · 044df67
1 parent 2c62f0d
commit 044df67
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
@@ -12,7 +12,7 @@ cmake_tests:
     rm -rf build || true
     mkdir build
     cd build
-    cmake -DCMAKE_CXX_FLAGS="-Wall -Werror=unused-variable -Wno-sign-compare" -DBUILD_BENCHMARKS=ON $GENERAL_CMAKE_OPTIONS -DKokkos_ENABLE_SERIAL=ON ..
+    cmake -DCMAKE_CXX_FLAGS="-Wall -Werror=unused-variable -Werror=parentheses -Wno-sign-compare" -DBUILD_BENCHMARKS=ON $GENERAL_CMAKE_OPTIONS -DKokkos_ENABLE_SERIAL=ON ..
     make -j 4
     ctest -j 2 --output-on-failure --timeout 5 -LE test_on_Release_only --output-junit tests.xml
   artifacts:

diff --git a/tests/geometryXVx/geometryMX/fluidspecies.cpp b/tests/geometryXVx/geometryMX/fluidspecies.cpp
@@ -97,7 +97,7 @@ TEST(GeometryXM, KineticFluidSpecies)
             EXPECT_EQ(ddc::discrete_space<IDimSp>().charges()(isp), kinetic_charges(isp));
             EXPECT_EQ(ddc::discrete_space<IDimSp>().masses()(isp), kinetic_masses(isp));
 
-        } else if (nb_kinspecies + 1 <= isp.uid() < nb_kinspecies + nb_fluidspecies) {
+        } else if (nb_kinspecies + 1 <= isp.uid() && isp.uid() < nb_kinspecies + nb_fluidspecies) {
             EXPECT_EQ(ddc::discrete_space<IDimSp>().charges()(isp), fluid_charges(isp));
             EXPECT_EQ(ddc::discrete_space<IDimSp>().masses()(isp), fluid_masses(isp));
         }
@@ -208,4 +208,4 @@ TEST(GeometryXM, KineticFluidAdiabaticSpecies)
             EXPECT_EQ(ddc::discrete_space<IDimSp>().charges()(isp), charge_adiabspecies);
         }
     });
-}
+}