Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run test suite in GH Actions #195

Closed
wants to merge 202 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
202 commits
Select commit Hold shift + click to select a range
c664564
remove RevisionHash and change all record helper methods to accept ra…
pospi Feb 22, 2022
4398682
Run `cargo test` in GH Actions
harlantwood Feb 22, 2022
f00392c
change calculate_identity_address() to use hash of externally-facing …
pospi Feb 23, 2022
138c68f
remove RevisionHash from remaining core libs & definition
pospi Feb 24, 2022
3f85185
drop all refs to deprecated RevisionHash in favour of raw HeaderHash
pospi Feb 24, 2022
6df2251
fix generics to match new method signatures, missing ByHeader imports…
pospi Feb 24, 2022
58eb4a6
reimplement identity read/write helpers to directly store UUIDs in th…
pospi Feb 24, 2022
74ce274
adjust trait bounds for identity managing methods to reflect new stor…
pospi Feb 24, 2022
3981d6d
define identifier EntryDefs using verbose macro as substitution for p…
pospi Feb 24, 2022
8963472
fix EntryDefs for index pointers not being defined, and use of entry_…
pospi Feb 24, 2022
3901a70
reimplement temporary 'all' index logic to use non-Path-based indexin…
pospi Feb 24, 2022
6addbf5
comment UUID helpers lib, remove unneeded method, comment method to d…
pospi Feb 24, 2022
a9d65e4
rename crate to more appropriate naming
pospi Feb 24, 2022
db1c0d1
pin GraphQL client module to same version as schema module
pospi Feb 24, 2022
e0f1d3f
fix release tag match, not a real regex
pospi Feb 25, 2022
1ef46dd
remove unnecessary double-handling of null connection URI
pospi Feb 25, 2022
1e77e84
refactor autoconnect logic out of explorer app into Holochain connect…
pospi Feb 25, 2022
859d35d
remove todo
pospi Feb 25, 2022
f974d80
update scripts to use pnpm commands so workspace is aware of pnpm-spe…
pospi Feb 25, 2022
cbf2dd5
update CI scripts to use pnpm & remove old sim2h network server start…
pospi Feb 25, 2022
86ed208
pnpm installed locally in GH CI
pospi Feb 25, 2022
dfb3521
unignore Cargo.lock to see if it makes GH actions use same deps
pospi Feb 25, 2022
25bf74a
add Cargo lockfile
pospi Feb 25, 2022
6ae65d2
fixes #199 see the issue context
Connoropolous Feb 25, 2022
2cacb29
remove console.log
Connoropolous Feb 25, 2022
3fb1efe
Merge pull request #201 from holo-rea/fix-for-199
pospi Feb 26, 2022
4e1255d
correctly parse datetime format without fractional seconds if returne…
pospi Feb 26, 2022
52e7741
fix the missing entry def for units
Connoropolous Feb 27, 2022
a1edfd3
fixes #206
Connoropolous Feb 28, 2022
d57513a
Merge branch 'sprout' of github.com:holo-rea/holo-rea into sprout
pospi Mar 1, 2022
1ebb329
fixes #208 - update multiple times
Connoropolous Mar 1, 2022
33fc388
Update record_helpers.rs
Connoropolous Mar 1, 2022
1e87c3f
Merge pull request #209 from holo-rea/fix-update-tree
pospi Mar 2, 2022
9d4ed13
Merge pull request #207 from holo-rea/fix-unit-measure
pospi Mar 2, 2022
b6ce528
update deps for latest HDK
pospi Mar 3, 2022
b0ae5a8
update lockfile
pospi Mar 3, 2022
f1effbe
update nix env for latest Holochain
pospi Mar 3, 2022
08476bd
update hdk revs in (outdated) module templates
pospi Mar 3, 2022
20aad9e
update for SignedHeaderHashed API change
pospi Mar 3, 2022
ec8f244
fix Unit fields not being public
pospi Mar 3, 2022
b429b2f
update existing entry field validation to use new validations API
pospi Mar 3, 2022
6b8cebd
fix method binding for all_agents query, though it doesn't yet seem t…
pospi Mar 3, 2022
8a7b287
add todo
pospi Mar 3, 2022
6c2aa53
fix EconomicResource mising name field
pospi Mar 3, 2022
d6092c7
update clean commands for latest Holonix
pospi Mar 9, 2022
834b66f
make test package private to prevent workspace-wide publish from incl…
pospi Mar 10, 2022
74cc4bf
fix PNPM package refs to interpret build folders correctly
pospi Mar 10, 2022
6ffdd16
remove build folders for node modules when cleaning
pospi Mar 10, 2022
ce2605f
update lockfile, client now refs unbuilt package but *hopefully* PNPM…
pospi Mar 10, 2022
6faabb1
add publishing instructions for node packages to developer docs
pospi Mar 10, 2022
1b1f757
mark node packages as non-private, publishConfig.directory handles th…
pospi Mar 10, 2022
7c37c49
update publishConfigs and remove manual package file munging which PN…
pospi Mar 10, 2022
be90c34
swap out workspace protocol ref in built version of GraphQL client mo…
pospi Mar 10, 2022
9daea44
update readme for GraphQL client module
pospi Mar 10, 2022
b9dbacd
downgrade GraphQL in tests, seems to cause errors with easygraphql-te…
pospi Mar 11, 2022
161951d
fix casing of parameter names in EconomicResource tests
pospi Mar 11, 2022
c5707f5
Add pnpm to nix-shell environment.
adaburrows Mar 14, 2022
e3fc37f
Merge pull request #217 from adaburrows/fix-default-nix
pospi Mar 15, 2022
07382a7
update lockfile
pospi Mar 15, 2022
6662187
update HDK
pospi Mar 15, 2022
4759451
update lockfile
pospi Mar 15, 2022
556b289
fix link deletion to only target entries in question
pospi Mar 16, 2022
d809c8e
implement alternative more flexible architecture for managing index u…
pospi Mar 16, 2022
906fb11
fix #212 contains & containedIn resolvers for EconomicResource
pospi Mar 16, 2022
2a0d98a
export serializeId from test helpers for use in tests which mix low-l…
pospi Mar 16, 2022
d29aa47
fix serialization errors in resource_links test; now passing
pospi Mar 16, 2022
cc1f55a
return correct paginated Relay structure for ResourceSpecification.co…
pospi Mar 16, 2022
45f1cb1
quick first pass at converting index zome return data to Relay-compat…
pospi Mar 16, 2022
623861e
update lockfile
pospi Mar 16, 2022
a2a6c8f
update conformingResources test for Relay API
pospi Mar 16, 2022
8175f81
only update EconomicResource container refs if changed
pospi Mar 16, 2022
9bf106a
refix economicResource link resolvers per new indexing API return format
pospi Mar 16, 2022
a7d6f9f
Merge branch 'sprout' into feature/197-configurable-indexing
pospi Mar 16, 2022
8fc1e0c
remove old indexing implementation, entirely superceded by automatic …
pospi Mar 16, 2022
2bc6030
update all index handler methods to transport-agnostic calling format
pospi Mar 16, 2022
a999c7c
fix tests for EconomicEvent / EconomicResource list API
pospi Mar 16, 2022
63e0730
start porting test for new Tryorama, but can't get past install anyway
pospi Mar 16, 2022
57681b2
fix EconomicResource index zome failing EntryDef checks
pospi Mar 16, 2022
aee0c9c
presume PNPM to be installed in Github CI as per new Nix config addition
pospi Mar 16, 2022
40a030f
bump package versions
pospi Mar 16, 2022
b42aed5
initial push
hackmd-deploy Mar 23, 2022
1b148eb
Merge pull request #227 from holo-rea/completions
Connoropolous Mar 24, 2022
781ae1d
rename happs folder to dna_bundles
Connoropolous Mar 24, 2022
eab164b
fix missing Agreement module in Holochain Cell mappings, make all DNA…
pospi Mar 26, 2022
65f4210
reorg bundle folders into single toplevel directory
pospi Mar 26, 2022
4aa142d
update readmes for new paths
pospi Mar 26, 2022
0552be1
update ignore file
pospi Mar 26, 2022
011f287
update paths in all configs, helper scripts and test harness
pospi Mar 26, 2022
a40b199
clean up build clean command
pospi Mar 26, 2022
a702503
Merge pull request #228 from holo-rea/rename-happs-to-dna-bundles
pospi Mar 26, 2022
f71eb21
move DNA bundle files in prep for templating
pospi Mar 26, 2022
ecb0204
move app bundle template, use single template & delete old dev-specif…
pospi Mar 26, 2022
6a1081d
change HC app ID to full suite now the sandbox can support it
pospi Mar 26, 2022
529f036
update manifest files & build scripts to allow split dev/release conf…
pospi Mar 26, 2022
48ff808
update Github release script to use new command
pospi Mar 26, 2022
a5faa23
update ignore file
pospi Mar 26, 2022
8fb6350
update docs to reflect new bundle manifest file structure & commands
pospi Mar 26, 2022
fbf4cc0
move completions file for tracking MVP features to docs dir
pospi Mar 26, 2022
d3ae97e
add the VfModule enum, use it throughout, and export it
Connoropolous Mar 28, 2022
957e2b0
switched order
hackmd-deploy Mar 30, 2022
2c5e547
Merge branch 'sprout' into completions
Connoropolous Mar 30, 2022
3d0290d
Merge pull request #237 from holo-rea/completions
Connoropolous Mar 30, 2022
bfde90b
add temporary workaround for Tryorama timeout so integration tests ca…
pospi Apr 3, 2022
8675452
remove comment
pospi Apr 8, 2022
1631266
remove util schema from modules list, it always gets included automat…
pospi Apr 8, 2022
d02fb9e
alphabetise default modules for clarity
pospi Apr 8, 2022
a24a60a
Merge pull request #236 from h-REA/234-vf-module-as-enum
pospi Apr 8, 2022
6c4719c
define VFModule enums as strings to avoid breakage when passed to vf-…
pospi Apr 8, 2022
e034d68
make sed command work cross platform mac and linux
Connoropolous Apr 8, 2022
d96a9f8
Merge pull request #241 from h-REA/make-cross-platform
Connoropolous Apr 8, 2022
a38175a
fix basic error blocking test running
Connoropolous Apr 12, 2022
a88be08
Merge pull request #243 from h-REA/basic-blocking-test-running-fixes
Connoropolous Apr 12, 2022
be89de7
make the integration tests more usable, and more informative
Connoropolous Apr 12, 2022
fae09c8
run them all
Connoropolous Apr 12, 2022
3b74c75
fix economic-resource broken test
Connoropolous Apr 12, 2022
8aa352f
update test report
Connoropolous Apr 12, 2022
12afd7b
hot fix the recursion bug in get_latest_header_hash
Connoropolous Apr 13, 2022
76b9e06
Merge branch 'sprout' into integration-test-usability
Connoropolous Apr 13, 2022
f86b5f9
update agent tests init logic for new tryorama
pospi Apr 13, 2022
06945fa
Update resource_logic.js
Connoropolous Apr 13, 2022
d0d2336
Update package.json
Connoropolous Apr 13, 2022
31a4d39
Delete integration-tests.sh
Connoropolous Apr 13, 2022
57db0c6
Update package.json
Connoropolous Apr 13, 2022
3e1a680
bump package versions
pospi Apr 13, 2022
092947f
update lockfile
pospi Apr 13, 2022
9cab72e
Merge pull request #245 from h-REA/integration-test-usability
pospi Apr 13, 2022
eda3a10
fix test running so that we don't hit non-deterministic cell order
Connoropolous Apr 21, 2022
ebbc643
add note to dev docs about RUST_LOG tuning
Connoropolous Apr 22, 2022
f6ec123
add a link to further external help
Connoropolous Apr 22, 2022
d6c785f
cleanup
Connoropolous Apr 22, 2022
2a326a1
get test/satisfaction to place where its failing on implementation logic
Connoropolous Apr 22, 2022
51f792e
Merge pull request #259 from h-REA/fix-test-running
Connoropolous Apr 22, 2022
e9eda04
add comment in the file about the status of the tests in the file
Connoropolous Apr 22, 2022
c534d99
extend comment
Connoropolous Apr 22, 2022
acec27f
Merge pull request #260 from h-REA/255-test-satisfaction
Connoropolous Apr 22, 2022
e172778
skip agent and social-architectures tests for now
Connoropolous Apr 23, 2022
2116fdd
fix the initial error by using mockIdentifier()
Connoropolous Apr 23, 2022
882edd6
Merge pull request #261 from h-REA/254-test-flows
Connoropolous Apr 24, 2022
af35cfd
reduce log verbosity in tests
pospi Apr 25, 2022
d93559b
fix config and declarations to correctly wire up Agreement DNA with E…
pospi Apr 25, 2022
79a5beb
fix config bugs in observation <> planning inter-DNA calls
pospi Apr 25, 2022
f06c63f
fix missing index zome configs for Proposal DNA
pospi Apr 25, 2022
48a67e1
fix more mis-wired indexes in default module arrangement
pospi Apr 25, 2022
69415d3
fix process index zome names in config
pospi Apr 25, 2022
f17bc76
fix for revisionId which was not getting serialized/deserialized by t…
Connoropolous Apr 25, 2022
13d4987
addresses #253 -> test_agreement_links.js needs updating to new tryor…
Connoropolous Apr 25, 2022
3833a5c
fixes for #253, partial progress
Connoropolous Apr 25, 2022
e2428b1
fixes for #246 test/process
Connoropolous Apr 25, 2022
ea2f282
add backlink to issue tracker
Connoropolous Apr 25, 2022
68ef1a6
further fixes for test/fulfillment
Connoropolous Apr 26, 2022
a44147d
Merge branch 'sprout' of github.com:holo-rea/holo-rea into sprout
Connoropolous Apr 26, 2022
e1a3346
fix agreement index zome missing entrydefs
pospi Apr 26, 2022
9fa89ad
sort IDs clientside in agreement link test pending resolution to #220
pospi Apr 26, 2022
7491cfe
fix most of test/specification #249
Connoropolous Apr 26, 2022
08a9702
fix agreement index update method names in DNA config
pospi Apr 26, 2022
7c66add
index config fixes for observation, planning & specification DNAs
pospi Apr 26, 2022
6699032
fix empty config for locally-hosted index zome throwing an unnecessar…
pospi Apr 26, 2022
f55a9cc
Merge branch 'sprout' of github.com:holo-rea/holo-rea into sprout
pospi Apr 26, 2022
811645e
fixes #246 test/process
Connoropolous Apr 26, 2022
e0b11fb
almost complete #254 test/flows
Connoropolous Apr 26, 2022
eaa6038
fixes related to #248 test/core-architecture. see that issue for rema…
Connoropolous Apr 26, 2022
ca3fcac
fixes #248
Connoropolous Apr 26, 2022
a794029
fix nonstandard name for EconomicEvent index zome in Fulfillment
pospi Apr 30, 2022
1bc911c
only check record ID portion of EconomicEvent.fulfills in assertion
pospi Apr 30, 2022
056d071
add helpers for sorting lists of records with IDs as raw buffers (for…
pospi May 2, 2022
08de190
fix assertions in Fulfillment tests for ordering, list output structs…
pospi May 2, 2022
0fd2550
fix satisfaction test assertions with workarounds for sorting, list A…
pospi May 4, 2022
5560ebb
minor update to assertion message
pospi May 4, 2022
3574f1c
first pass at porting Proposal tests to new Tryorama #251
pospi May 4, 2022
9720a46
fix Proposal & Process structs using old Timestamp instead of new Dat…
pospi May 4, 2022
dcebb12
fix missing index config for Proposal zome
pospi May 4, 2022
eaeaf76
update Proposal CRUD tests to use revisions #251
pospi May 4, 2022
4bb7ff5
fix missing EntryDefs in proposal index zomes
pospi May 4, 2022
20171e5
update ProposedIntent tests to use revisions for update/delete
pospi May 4, 2022
7314df0
fix remote_auth zome not being included in planning DNA
pospi May 4, 2022
5a79ac6
fix ProposedIntent not declaring EntryDef needed to store credentials…
pospi May 4, 2022
757dc06
fix missing entryDef in intent index zome
pospi May 4, 2022
a173b47
fix ProposedIntent tests erroring due to undefined ordering
pospi May 4, 2022
180b749
fix incorrect index name for Proposal.publishedTo
pospi May 4, 2022
449f237
update ProposedTo tests to use revisions for deletion
pospi May 4, 2022
d502568
implement ID translation method to allow cross-DNA resolvers to funct…
pospi May 4, 2022
7194171
fix Satisfaction & Fulfillment resolvers not dealing with cross-DNA l…
pospi May 4, 2022
7943db0
export cell remapping helper temporarily for use in tests
pospi May 4, 2022
f362792
fix assertions for EconomicEvent.satisfies / fulfills by remapping Ce…
pospi May 4, 2022
c903077
fix passing param adjusted for CellId to satisfaction resolver
pospi May 4, 2022
459c8c9
fix errors due to nondeterministic ordering in flow records tests
pospi May 4, 2022
98743aa
workaround result sorting in test assertions for proposedIntent #251
pospi May 16, 2022
c2357a2
#254 fix satisfaction result handling helper to match paginated respo…
pospi May 16, 2022
887fd9a
update logic for anchored records to encode string-based index paths …
pospi May 16, 2022
a55571b
#249 fix unit ID assertion in tests to factor in DnaHash portion of ID
pospi May 16, 2022
7691ac2
fix wrong type used to constrain Unit deletion logic #249
pospi May 16, 2022
f0dcba3
remove debug
pospi May 16, 2022
30eba4e
remove overly verbose logging in index management methods
pospi May 16, 2022
458daed
WIP intermediate state for #264 so as to not cause complex config iss…
pospi May 16, 2022
aefedb0
remove unneeded storage consts as per #263
pospi May 16, 2022
7dc7e88
Update test.yml
Connoropolous May 19, 2022
098ebe6
Update test.yml
Connoropolous May 19, 2022
3d7de31
Update test.yml
Connoropolous May 19, 2022
aac3c89
increase timeout
Connoropolous May 19, 2022
e51e266
Delete config.yml
Connoropolous May 19, 2022
2339d60
Delete .travis.yml
Connoropolous May 19, 2022
c995019
merge
Connoropolous May 19, 2022
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 68 additions & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,68 @@
name: Checks

on: [push, pull_request]

jobs:
checks:
timeout-minutes: 45
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [ubuntu-20.04, macos-11]
fail-fast: false

steps:
- name: Fetch source code
uses: actions/checkout@v2

- uses: actions/cache@v2
with:
path: |
~/.cargo/bin/
~/.cargo/registry/index/
~/.cargo/registry/cache/
~/.cargo/git/db/
.cargo/bin/
.cargo/registry/index/
.cargo/registry/cache/
.cargo/git/db/
target/
key: ${{ runner.os }}-cargo-${{ hashFiles('**/Cargo.lock') }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this repo has the rather anomalous behavior of not checking the Cargo.lock file into git, which as I understand it has its reasons, but from my experience has had some real downsides

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in my other one, I use Cargo.toml, while realizing that that's not best practice

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this repo has the rather anomalous behavior of not checking the Cargo.lock file into git, which as I understand it has its reasons, but from my experience has had some real downsides

Hmm I think this is actually best practice for libraries (but not binaries) — https://doc.rust-lang.org/cargo/faq.html#why-do-binaries-have-cargolock-in-version-control-but-not-libraries

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in my other one, I use Cargo.toml, while realizing that that's not best practice

Thanks, should update

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That kinda makes sense. The zomes themselves are more like binaries, while the things in lib are libraries, so 🤷 I'm not sure

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That kinda makes sense. The zomes themselves are more like binaries, while the things in lib are libraries, so 🤷 I'm not sure

More nuanced suggestion here: https://stackoverflow.com/a/63727523

restore-keys: |
${{ runner.os }}-cargo-

- name: Setup Xcode version
if: ${{ runner.os == 'macOS' }}
uses: maxim-lobanov/[email protected]
with:
xcode-version: latest-stable

- name: Check macOS version
if: ${{ runner.os == 'macOS' }}
run: sw_vers

- name: Set up nix
uses: cachix/install-nix-action@v16
with:
nix_path: nixpkgs=channel:nixos-21.05
extra_nix_config: |
substituters = https://cache.nixos.org https://cache.holo.host https://ci-builds.cachix.org https://holochain-ci.cachix.org
trusted-public-keys = cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY= cache.holo.host-1:lNXIXtJgS9Iuw4Cu6X0HINLu9sTfcjEntnrgwMQIMcE= cache.holo.host-2:ZJCkX3AUYZ8soxTLfTb60g+F3MkWD7hkH9y8CgqwhDQ= ci-builds.cachix.org-1:fxB0+h/MMlCpXf6hFsQM31YpHbaQoRmcNPNHwDUkXA4= holochain-ci.cachix.org-1:5IUSkZc0aoRS53rfkvH9Kid40NpyjwCMCzwRTXy+QN8=
Comment on lines +44 to +50
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should consolidate between this way of defining these, and the nix.conf way that is currently at play. I have zero attachment to which way it goes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am referring to this file, and the command in the Release CI workflow that references it
https://github.com/holo-rea/holo-rea/blob/sprout/.github/nix.conf


- uses: cachix/cachix-action@v10
with:
name: ci-builds
authToken: "${{ secrets.CACHIX_TOKEN }}"

- name: Inspect nix.conf
run: cat ~/.config/nix/nix.conf

- name: Install recent bash, and set as NIX_BUILD_SHELL # needed by macos, which has an older bash incompatible with nix
if: ${{ runner.os == 'macOS' }}
run: echo "NIX_BUILD_SHELL=$(nix-build -A bashInteractive '<nixpkgs>')/bin/bash" >> $GITHUB_ENV

- name: Prepare Nix environment
run: nix-shell --command "echo Completed"

- run: nix-shell --pure --run 'cargo build'
- run: nix-shell --pure --run 'cargo test'