fixes #208 - update multiple times #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the original code didn't suit this context, and it was adapted from h-be/Acorn or hdk_crud. It didn't suit because in Acorn HeaderHash is used as "id" where as in holo-rea EntryHash is used as "id" hdk_crud creates a flat update tree, where all updates reference the original header holo-rea is supposed to create a branching Update tree, which this now allows for. However, this implementation is still very naive, and assumes that in fact the Update tree mostly just nests children in one sequence, more like an array than a tree. This won't hold true in practice, as we're dealing in offline-friendly distributed systems. Solving this properly relates to issue #196 conflict resolution
pospi
approved these changes
Mar 2, 2022
There was a problem hiding this comment.
This is great! Should resolve bugs resulting from changes to the update logic; and should work well as-is for linear revisions to the same update. Though, I expect we will eventually want those to be detected as conflicts when #196 is implemented?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #208
full background is in the commit message itself, but also here:
the original code didn't suit this context, and it was adapted from h-be/Acorn or hdk_crud.
It didn't suit because in Acorn HeaderHash is used as "id" where as in holo-rea EntryHash is used as "id"
hdk_crud creates a flat update tree, where all updates reference the original header
holo-rea is supposed to create a branching Update tree, which this now allows for.
However, this implementation is still very naive, and assumes that in fact the Update tree
mostly just nests children in one sequence, more like an linked list than a tree. This won't hold
true in practice, as we're dealing in offline-friendly distributed systems. Solving this properly
relates to issue #196 conflict resolution