Add docker support, new param is introduced --docker-image
#6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agustinhenze
force-pushed
the
docker-support
branch
2 times, most recently
from
02567cb to
873e3a3
Compare
piuparts.1.txt
Outdated
| Use schroot session named SCHROOT-NAME for the chroot, instead of building a new one with debootstrap. | ||
| Use schroot session named SCHROOT-NAME for the testing environment. | ||
|
|
||
| *--docker-image='DOCKER-IMAGE':: |
There was a problem hiding this comment.
It's missing a * to close the bold section after --docker-image
agustinhenze
force-pushed
the
docker-support
branch
from
873e3a3 to
ca07c9e
Compare
|
Maybe you should add |
|
@agustinhenze I'm probably not going to test or use it ... but looks good from a quick glance. |
|
@anbe42 Thank you for doing review :). Please take a look again to see if everything is ok for you |
|
@agustinhenze Please rebase the pull request on develop, not master. Targeting develop not master. Make the changelog entry a multimaint one. (with |
agustinhenze
force-pushed
the
docker-support
branch
from
c5712b9 to
c6adf30
Compare
|
@anbe42 done |
|
ACK |
agustinhenze
force-pushed
the
docker-support
branch
2 times, most recently
from
2292e3a to
9800785
Compare
e.g. piuparts --docker-image debian:unstable package.deb It only supports overlay2 for now and it uses the `MergedDir` layer where piuparts can access, add, edit and remove files easily. Signed-off-by: Agustin Henze <[email protected]>
Signed-off-by: Agustin Henze <[email protected]>
Signed-off-by: Agustin Henze <[email protected]>
Signed-off-by: Agustin Henze <[email protected]>
Signed-off-by: Agustin Henze <[email protected]>
Signed-off-by: Agustin Henze <[email protected]>
agustinhenze
force-pushed
the
docker-support
branch
from
9800785 to
3320e76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
e.g. piuparts --docker-image debian:unstable package.deb
It only supports overlay2 for now and it uses the
MergedDirlayerwhere piuparts can access, add, edit and remove files easily.