Skip to content

Fix dependency compatibility issues in data recipes #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rsujeevan wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix dependency compatibility issues in data recipes #237

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions data/any_env2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,9 +119,9 @@ class FreshEnvData(CustomData):
# NOTE: Keep @wrap_create on a single line
# NOTE: If want to share cache across recipes, can set cache_env=True and set id=<some unique identifier, like myrecipe12345>
# Below caches the env into "id" folder
# @wrap_create(pyversion="3.11", install_h2oaicore=False, install_datatable=True, modules_needed_by_name=["pandas==1.5.3"], cache_env=True, file=__file__, id="myrecipe12345")
# @wrap_create(pyversion="3.11", install_h2oaicore=False, install_datatable=True, modules_needed_by_name=["numpy==1.24.4", "pandas==1.5.3"], cache_env=True, file=__file__, id="myrecipe12345")
# Below does not cache the env
@wrap_create(pyversion="3.11", install_h2oaicore=False, install_datatable=True, modules_needed_by_name=["pandas==1.5.3"], file=__file__)
@wrap_create(pyversion="3.11", install_h2oaicore=False, install_datatable=True, modules_needed_by_name=["numpy==1.24.4", "pandas==1.5.3"], file=__file__)
def create_data(X=None):
import os
import datatable as dt
Expand All @@ -133,7 +133,7 @@ def create_data(X=None):
my_path = os.path.dirname(__file__)

import pandas as pd
assert pd.__version__ == "1.1.5", "actual: %s" % pd.__version__
assert pd.__version__ == "1.5.3", "actual: %s" % pd.__version__

url = "http://data.un.org/_Docs/SYB/CSV/SYB63_226_202009_Net%20Disbursements%20from%20Official%20ODA%20to%20Recipients.csv"
import urllib.request
Expand Down
6 changes: 3 additions & 3 deletions data/any_env3.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ class FreshEnvData(CustomData):
# NOTE: Keep @wrap_create on a single line
# NOTE: If want to share cache across recipes, can set cache_env=True and set id=<some unique identifier, like myrecipe12345>
# Below caches the env into "id" folder
# @wrap_create(pyversion="3.11", install_h2oaicore=False, install_datatable=True, modules_needed_by_name=["pandas==1.5.3"], cache_env=True, file=__file__, id="myrecipe12345")
# @wrap_create(pyversion="3.11", install_h2oaicore=False, install_datatable=True, modules_needed_by_name=["numpy==1.24.4", "pandas==1.5.3"], cache_env=True, file=__file__, id="myrecipe12345")
# Below does not cache the env
@wrap_create(pyversion="3.11", install_h2oaicore=False, install_datatable=True, modules_needed_by_name=["pandas==1.5.3"], file=__file__)
@wrap_create(pyversion="3.11", install_h2oaicore=False, install_datatable=True, modules_needed_by_name=["numpy==1.24.4", "pandas==1.5.3"], file=__file__)
def create_data(X=None):
import os
import datatable as dt
Expand All @@ -24,7 +24,7 @@ def create_data(X=None):
my_path = os.path.dirname(__file__)

import pandas as pd
assert pd.__version__ == "1.1.5", "actual: %s" % pd.__version__
assert pd.__version__ == "1.5.3", "actual: %s" % pd.__version__

url = "http://data.un.org/_Docs/SYB/CSV/SYB63_226_202009_Net%20Disbursements%20from%20Official%20ODA%20to%20Recipients.csv"
import urllib.request
Expand Down
6 changes: 3 additions & 3 deletions data/any_env4.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,10 @@
class FreshEnvData(CustomData):
# Specify the python package dependencies. Will be installed in order of list
# Below caches the env into "id" folder
# isolate_env = dict(pyversion="3.11", install_h2oaicore=False, install_datatable=True, modules_needed_by_name=["pandas==1.5.3"], cache_env=True, id="myrecipe12345")
# isolate_env = dict(pyversion="3.11", install_h2oaicore=False, install_datatable=True, modules_needed_by_name=["numpy==1.24.4", "pandas==1.5.3"], cache_env=True, id="myrecipe12345")
# Below does not cache the env
isolate_env = dict(pyversion="3.11", install_h2oaicore=False, install_datatable=True,
modules_needed_by_name=["pandas==1.5.3"])
modules_needed_by_name=["numpy==1.24.4", "pandas==1.5.3"])

@staticmethod
def create_data(X=None):
Expand All @@ -23,7 +23,7 @@ def create_data(X=None):
my_path = os.path.dirname(__file__)

import pandas as pd
assert pd.__version__ == "1.1.5", "actual: %s" % pd.__version__
assert pd.__version__ == "1.5.3", "actual: %s" % pd.__version__

url = "http://data.un.org/_Docs/SYB/CSV/SYB63_226_202009_Net%20Disbursements%20from%20Official%20ODA%20to%20Recipients.csv"
import urllib.request
Expand Down
2 changes: 1 addition & 1 deletion data/feature_selection_backward.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@


class BackwardFeatureSelection(CustomData):
_modules_needed_by_name = ["mlxtend"]
_modules_needed_by_name = ["mlxtend==0.23.4"]

@staticmethod
def create_data(X: dt.Frame = None) -> pd.DataFrame:
Expand Down
2 changes: 1 addition & 1 deletion data/feature_selection_bidirectional.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@


class BidirectionalFeatureSelection(CustomData):
_modules_needed_by_name = ["mlxtend"]
_modules_needed_by_name = ["mlxtend==0.23.4"]

@staticmethod
def create_data(X: dt.Frame = None) -> pd.DataFrame:
Expand Down
2 changes: 1 addition & 1 deletion data/feature_selection_exhaustive.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@


class ExhaustiveFeatureSelection(CustomData):
_modules_needed_by_name = ["mlxtend"]
_modules_needed_by_name = ["mlxtend==0.23.4"]

@staticmethod
def create_data(X: dt.Frame = None) -> pd.DataFrame:
Expand Down
2 changes: 1 addition & 1 deletion data/feature_selection_forward.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@


class ForwardFeatureSelection(CustomData):
_modules_needed_by_name = ["mlxtend"]
_modules_needed_by_name = ["mlxtend==0.23.4"]

@staticmethod
def create_data(X: dt.Frame = None) -> pd.DataFrame:
Expand Down