Skip to content

Add missing ecr login for internal bundle publish and refactor build steps #936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 18, 2025
Merged

Add missing ecr login for internal bundle publish and refactor build steps #936

merged 2 commits into from
Sep 18, 2025

Conversation

codyharris-h2o-ai
Copy link
Collaborator

  • Only run build on tags with v prefix
  • Add missing ecr login step for internal bundle publish
  • Refactor to perform bundle step once and share the artifact between the jobs
  • For internal publish, only check out the required Dockerfile instead of the entire repository

github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 18, 2025
View reviewed changes
pascal-pfeiffer
pascal-pfeiffer approved these changes Sep 18, 2025
View reviewed changes
Copy link
Collaborator

@pascal-pfeiffer pascal-pfeiffer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you! lgtm

@pascal-pfeiffer pascal-pfeiffer merged commit bb2b85d into main Sep 18, 2025
11 of 12 checks passed
@pascal-pfeiffer pascal-pfeiffer deleted the charris/fix-bundle-build branch September 18, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascal-pfeiffer pascal-pfeiffer pascal-pfeiffer approved these changes

@psinger psinger Awaiting requested review from psinger psinger is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codyharris-h2o-ai @pascal-pfeiffer