Fix characteristic discovery with no descriptors. (#863)

Avoid discovery of descriptors if there are no handles remaining. This reinstates the check removed in 853241b.
h2zero · Jan 16, 2025 · 3081bc1 · 3081bc1
1 parent 4464e3f
commit 3081bc1
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/src/NimBLERemoteCharacteristic.cpp b/src/NimBLERemoteCharacteristic.cpp
@@ -101,6 +101,12 @@ int NimBLERemoteCharacteristic::descriptorDiscCB(
 bool NimBLERemoteCharacteristic::retrieveDescriptors(const NimBLEUUID* uuidFilter) const {
     NIMBLE_LOGD(LOG_TAG, ">> retrieveDescriptors() for characteristic: %s", getUUID().toString().c_str());
 
+    // If this is the last handle then there are no descriptors
+    if (getHandle() == getRemoteService()->getEndHandle()) {
+      NIMBLE_LOGD(LOG_TAG, "<< retrieveDescriptors(): found 0 descriptors.");
+      return true;
+    }
+
     NimBLETaskData taskData(const_cast<NimBLERemoteCharacteristic*>(this));
     desc_filter_t  filter = {uuidFilter, &taskData};