Use cell- instead of char- array to accommodate filenames of unequal length in RFsens #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Barisevrenugur
changed the title
Barisevrenugur
added
enhancement
lukeje
reviewed
Nov 5, 2024
| @@ -95,7 +95,7 @@ | |||
| copyfile(qsensmap,fullfile(supplpath,spm_file(qsensmap,'filename'))); | |||
| try copyfile([spm_str_manip(qsensmap,'r') '.json'],fullfile(supplpath,[spm_file(qsensmap,'basename'), '.json'])); end %#ok<*TRYNC> | |||
| % substitute the corrected maps to the output structure | |||
| jobsubj.raw_mpm.(rfsens_params.input(ccon).tag) = char(corrected_structurals); | |||
| jobsubj.raw_mpm.(rfsens_params.input(ccon).tag) = cellstr(char(corrected_structurals)); | |||
There was a problem hiding this comment.
Does
jobsubj.raw_mpm.(rfsens_params.input(ccon).tag) = corrected_structurals;not work?
There was a problem hiding this comment.
Due to nature of error, I was fixated to quickly correcting char ---> cell, have not really checked or cared what data type is corrected_structurals, if it is already a cell-array, of course it should just work to delete the char (instead of adding cellstr). I will change if thats the case
lukeje
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
As standard, the files appear with same lengths as block-names (all of our test data has same file names formatted as a block). However, certain operations (BIDSification for one) might cause file names to differ. In such a case, the following line in RFsens correction causes an error further down the processing:
hMRI-toolbox/hmri_create_RFsens.m
Line 98 in ffa8444
because of using a char-array instead of a cell-array.
This minimal change solves this problem.
Testing
This simple change was tested successfully with our demo-data set with the changed MTw file names as:
Namely: the toolbox without the change in this PR gives an error whereas this PR completes the processing without a problem.
Reference
This PR implements the change suggested here:
#107 (comment)