Feature/allow recaptcha uids greater 1000 - #24
Open
kathangeorg wants to merge 2 commits into
Open
Conversation
…000)
Do not iterate from 1 to 1000 and check if there is a matching #g-recaptcha-{uid} div on current site, but iterate over existing .g-recaptcha elements and call grecaptcha.render(...) based on that .g-recaptcha elements.
|
#21 already solved this issue. |
derhecht
approved these changes
Nov 13, 2018
derhecht
left a comment
derhecht
left a comment
There was a problem hiding this comment.
But I would recommend @KittenCoder code minus code formatting changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because of
for (var i = 1; i <= 1000; ++i) {...}.g-recaptcha fields with a uid >1000 are not rendered. Therfore I changed theaddJsFooterInlineCodepart.