Correctly run clippy in CI

[baumanj]

Clippy leverages cargo check, so running it after other tests may cause some lints to not be triggered. To increase effectiveness (and move fatal errors toward the bottom of the CI output), run clippy first.

[thesentinels]

Thanks for the pull request! Here is what will happen next:

1. Your PR will be reviewed by the maintainers
2. If everything looks good, one of them will approve it, and your PR will be merged.

Thank you for contributing!

[christophermaier]

Looks good, but can you elaborate a bit on the following?

so running it after other tests may cause some lints to not be triggered.

[raskchanky]

@christophermaier I'm guessing the issue is that running cargo check after doing cargo build or cargo test won't actually build anything, since cargo is smart enough to detect that no code was changed.

[christophermaier]

Hrmm... interesting 🤔

Does that suggest that we'd need to run cargo clean before running clippy? That seems a tad extreme.

[baumanj]

Does that suggest that we'd need to run cargo clean before running clippy? That seems a tad extreme.

In this case, I think it suffices to move it to the first position so that we don't have any previous artifacts, but it is indeed possible for clippy to miss things on account of the erroneous code not being reconsidered at all.

See rust-lang/rust-clippy#2604
and rust-lang/cargo#6664

[christophermaier]

@raskchanky @baumanj Cool, thanks for all that. 👍