Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frog Says NFC Tag #38

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Frog Says NFC Tag #38

wants to merge 9 commits into from

Conversation

j0lynN-Y
Copy link

No description provided.

@qcoral
Copy link
Member

qcoral commented Jan 27, 2025

hey!! awesome job on this - could you update your submission to follow the formatting of the example? Link here:

https://github.com/hackclub/asylum/tree/main/designs/nfc_keytags/hack_club_keytag

specifically add a README.md with a picture of your keytag. Thanks!!! will review soon

@souptik-samanta
Copy link
Contributor

the cavity for the nfc tag is not present
check this out
https://github.com/hackclub/asylum/blob/main/designs/nfc_keytags/README.md

Copy link

Hey!! awesome job on this asylum submission. Can't wait to you build it.%0A%0AThis is just a friendly reminder to make sure your PR follows the example format, including directory structure:%0A%0A- For weather stations: Example here%0A- For NFC tags: Example here%0A%0AThe most important part is that you have a README.md file documenting your design. Make sure there are images of your design in it! Otherwise it will not be accepted.%0A%0AThis is an automated message, so you can ignore it if you have everything already! %0A%0ASend a message in #asylum once you've made the changes - you'll get your PR reviewed faster

Copy link

Hey!! awesome job on this asylum submission. Can't wait to see you build it.

This is just a friendly reminder to make sure your PR follows the example format, including directory structure:

The most important part is that you have a README.md file documenting your design. Make sure there are images of your design in it! Otherwise it will not be accepted.

This is an automated message, so you can ignore it if you have everything already!

Send a message in #asylum once you've made the changes - you'll get your PR reviewed faster

@Piplup7575
Copy link
Member

Can you add an image to your readme.md?
Cavity is also not properly present, it is still filled in (see below)

@jo
id U078SNVHSRK

image

filled in cavity
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants