Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add my wys demake #100

Merged
merged 7 commits into from
Feb 14, 2025
Merged

add my wys demake #100

merged 7 commits into from
Feb 14, 2025

Conversation

DJ-Laser
Copy link
Contributor

@DJ-Laser DJ-Laser commented Feb 4, 2025

Adds would you slug (will you snail demake lol)

Copy link

vercel bot commented Feb 4, 2025

@DJ-Laser is attempting to deploy a commit to the Hack Club Team on Vercel.

A member of the Team first needs to authorize it.

@DJ-Laser
Copy link
Contributor Author

DJ-Laser commented Feb 4, 2025

sorry acon this code is hella jank with classes and stuff but i love rust and java too much (oop and traits are epic :D)

@acornitum acornitum added the needs review needs acon to check over it , ,,,, label Feb 4, 2025
@acornitum
Copy link
Contributor

hey! could you directly add your code/files in this folder too?

@acornitum acornitum removed the needs review needs acon to check over it , ,,,, label Feb 6, 2025
@DJ-Laser
Copy link
Contributor Author

DJ-Laser commented Feb 7, 2025

alright i added the files directly instead of in a submodule, sorry for the inconvenience

@acornitum acornitum added the needs review needs acon to check over it , ,,,, label Feb 7, 2025
@acornitum
Copy link
Contributor

which file do I run to play this? :"D Also, would it be possible for you to not commit the packages and instead just add a requirements.txt of the things needed to be downloaded?

@acornitum acornitum removed the needs review needs acon to check over it , ,,,, label Feb 9, 2025
@DJ-Laser
Copy link
Contributor Author

DJ-Laser commented Feb 9, 2025

It has a pyproject.toml - like requirements.txt but modern. Just cd into the dir and run pip install .
ill remove the nix packages if you want since theyre only needed so i can run the game bc nix doesn't have circutpy in nixpkgs

@DJ-Laser
Copy link
Contributor Author

DJ-Laser commented Feb 9, 2025

For which file it's src/main.py just like all the others but the code is in the src folder lol

@DJ-Laser
Copy link
Contributor Author

commenting to let you know this is ready for the review tag!

@acornitum acornitum added the needs review needs acon to check over it , ,,,, label Feb 14, 2025
im using the cyrillli fork but they said remove the nix packages so it would be getting the one from pypi
@acornitum
Copy link
Contributor

This is cool! The controls are really smooth, and the animations are really satisfying to watch. I especially like how the eyes follow the snail! This is close to getting merged!

One thing - could you add a high score on screen? When the score resets when I die, I often can't tell what I'm at or if I've made any progress. I think a high score would make the gameplay more fun!

On a similar note - a start/end screen would be great, but optional.

I really like this game! The gameplay is really great :D Can't wait to see it when you've made that change.

Note: don't open a new PR, just commit changes to this current thread + send a comment when changes have been made!

@acornitum acornitum merged commit 731ead8 into hackclub:main Feb 14, 2025
1 check failed
@acornitum
Copy link
Contributor

wait ok i accidentally merged it 😭 when you make the change i'll send the form to fill out ahaha :pf:

@DJ-Laser
Copy link
Contributor Author

Alright I'll make a new pr lmao

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review needs acon to check over it , ,,,,
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants