Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Smokey Bear Game #103

Merged
merged 8 commits into from
Feb 14, 2025
Merged

Added Smokey Bear Game #103

merged 8 commits into from
Feb 14, 2025

Conversation

theamazing0
Copy link
Contributor

Slack username: Samvid
Game has a 25 second time limit in which the player tries to optimize their time to collect the best items to help Smokey prepare for hibernation. Players can retry the game to try to beat their old scores.

Copy link

vercel bot commented Feb 4, 2025

@theamazing0 is attempting to deploy a commit to the Hack Club Team on Vercel.

A member of the Team first needs to authorize it.

@acornitum acornitum added the needs review needs acon to check over it , ,,,, label Feb 4, 2025
@acornitum
Copy link
Contributor

Hey! Running this error even when I have installed requirements.txt. Do you know how to fix this?

image

@acornitum acornitum removed the needs review needs acon to check over it , ,,,, label Feb 6, 2025
@theamazing0
Copy link
Contributor Author

Ah looks like I forgot to update the requirements.txt after my update, Should be fixed with latest commit

@acornitum acornitum added the needs review needs acon to check over it , ,,,, label Feb 6, 2025
@DominicTYLau
Copy link

Hi, it’s running now and the art is amazing. Please add some instructions on how to play in the README file.

@theamazing0
Copy link
Contributor Author

Thanks, added in the latest commit!

@acornitum
Copy link
Contributor

I really like the art if your game! The background is especially nice - the colors go really well together, and I like how the birds are animated.

This is close to getting merged, but there are just a few things I want to see you improve on before I do so:

  • The bear is currently not very visible along the background - something artists do when having dark objects against dark background is add white highlights to the outline! That will make it more visible but mostly still keep the same colors on the main subject.
  • A start screen would be nice!
  • On the end screen, I'd really appreciate it if you wrote something like "score: [number]" instead of just the number so that I know what it represents! On that similar note, maybe make it a different color like white or something so that it's more visible?
  • Also, a count down timer would really nice - I didn't really know what the goal of the game was until I read your comment. Let the players know that there is a timer counting down!

Thanks so much for submitting! Can't wait to play when you've done those changes.

Note: don't open a new PR, just commit changes to this current thread + send a comment when changes have been made!

@acornitum acornitum removed the needs review needs acon to check over it , ,,,, label Feb 8, 2025
@theamazing0
Copy link
Contributor Author

  • Added a light colored highlight to the bear
  • Added a new screen for start with night/day variants like the mountain backdrop
  • added a score label and fixed the color
  • added a countdown timer in the form of a border around the screen that slowly disappears, giving a sense of time without having to take up too much place on the actual gameplay area
  • also made some fixes to the removal of items after a round that i didn't notice earlier

@acornitum
Copy link
Contributor

running into an error; get rid of the hw_accel part?

image

@theamazing0
Copy link
Contributor Author

Make sure you don't have the upstream version of blinka-displayio-pygamedisplay installed and only Cyril's fork which is specified in the requirements.txt. I can remove it on the published version if you would like, but it should work if the correct dependencies are installed. The change wasn't made now, it was present when you tested earlier so I think it's just a dependency version mismatch. Thanks!

@acornitum acornitum added the needs review needs acon to check over it , ,,,, label Feb 14, 2025
@acornitum
Copy link
Contributor

Nice! Looks much better.

Going to merge it now - fill out the form here: https://forms.hackclub.com/t/isDdJtrnrvus

Thanks for submitting!

@acornitum acornitum merged commit b6cdc3f into hackclub:main Feb 14, 2025
1 check failed
@acornitum acornitum removed the needs review needs acon to check over it , ,,,, label Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants