Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add my janky rhythm game #112

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

username123115
Copy link

I wrote a very janky rhythm game, I plan on adding a buzzer to my hackapet to make it work. Right now it's not very fun because you can't win but it's easy to extend the tracks

Copy link

vercel bot commented Feb 4, 2025

@coffecat24623 is attempting to deploy a commit to the Hack Club Team on Vercel.

A member of the Team first needs to authorize it.

@acornitum acornitum added the needs review needs acon to check over it , ,,,, label Feb 4, 2025
@tanmayrajk
Copy link
Contributor

tanmayrajk commented Feb 5, 2025

Running the game gives the error OSError: Unsupported BMP header type (56). This happened with me too after I'd pushed the game for some reason. The way I'd fixed it was to export all my assets as fake .bmp files. I exported all the assets as .png and then changed their formats to .bmp.

@acornitum
Copy link
Contributor

This runs for me! I get this was probably rushed for the deadline and it's a good start - I like the visual feedback I get when I press any of the buttons!

However, here are some things I'd like to see improved upon before I merge it:

  • Currently, when the music and beat runs out, there's nothing to do in the game! Maybe display a score and restart screen so that the player is able to play it again?
  • Music and beats don't line up - the music starts way before the notes start going onto page. Maybe try making both of them start on sync, even if their rhythms don't line up?
  • A start screen would be nice! I think this is especially important for rhythm games because the player needs to be able to start when they're ready, not on boot (I was caught off guard haha)

Thanks so much for submitting! Can't wait to see what this game when you've made those changes :D If you could commit them here in <1 week (or just asap), that would be amazing!

Note: don't open a new PR, just commit changes to this current thread + send a comment when changes have been made!

@acornitum acornitum removed the needs review needs acon to check over it , ,,,, label Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants