Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wizard game resbmit #115

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

wizard game resbmit #115

wants to merge 3 commits into from

Conversation

irstupid
Copy link

@irstupid irstupid commented Feb 5, 2025

my very very very last minute re submission fixing me accidentally adding my entire instillation of circuit python. at least thats how i understand it i have no idea what i'm doing :)

Copy link

vercel bot commented Feb 5, 2025

@irstupid is attempting to deploy a commit to the Hack Club Team on Vercel.

A member of the Team first needs to authorize it.

@acornitum acornitum added the needs review needs acon to check over it , ,,,, label Feb 5, 2025
@tanmayrajk
Copy link
Contributor

I'd suggest two things to make it better.

  • First is to make a simple restart screen instead of quitting the game when the player dies.
  • The second is changing the senstivity of the buttons. It seems like if i just press the button for more than few milliseconds it considers it as more than one press.

@tanmayrajk
Copy link
Contributor

tanmayrajk commented Feb 5, 2025

    keys = pygame.key.get_pressed()
    if keys[pygame.K_LEFT]:
        if state == 2:
            playerPos -= 1
        else:
            card -= 1
    if keys[pygame.K_RIGHT]:
        if state == 2:
            playerPos += 1
        else:
            card += 1

Instead of using pygame.key.get_pressed() doing it with events would fix your keypress issue. Something like this:

for event in pygame.event.get():
       if event.type == pygame.QUIT:
           pygame.quit()
           break
       if event.type == pygame.KEYDOWN:
               if event.key == pygame.K_SPACE:
                   #do something

@acornitum
Copy link
Contributor

This is cool! I really enjoy the art. It reminds me of Slay the Spire - another game that has to do with using cards as moves in a dungeon! The animations you have there are adorable, and I love the way you draw the goblins.

This is very close to getting merged - as @tanmayrajk mentioned, could you add a start screen?

Thank you so much for submitting! Can't wait to play this after :D

Note: don't open a new PR, just commit changes to this current thread + send a comment when changes have been made!

@acornitum acornitum removed the needs review needs acon to check over it , ,,,, label Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants