Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added how2cat #62

Merged
merged 3 commits into from
Feb 14, 2025
Merged

added how2cat #62

merged 3 commits into from
Feb 14, 2025

Conversation

sssyntax
Copy link
Contributor

@sssyntax sssyntax commented Feb 1, 2025

slack user: syntax

Copy link

vercel bot commented Feb 1, 2025

@sssyntax is attempting to deploy a commit to the Hack Club Team on Vercel.

A member of the Team first needs to authorize it.

@true-Grand
Copy link

W

@acornitum acornitum added the needs review needs acon to check over it , ,,,, label Feb 1, 2025
@acornitum
Copy link
Contributor

I love this!! The animations are absolutely adorable. I love the tiny details you put in - from the flicking of the tail, to the cat flicking its ears when getting rubbed on its head - it's so cute.

I really want to merge this, but there's one thing that I want changed - the actual hackapet only has 3 buttons, so would it be possible for you to remap the key presses to only 3 buttons? (What a lot of people do is let two buttons be an action in order to fit it all in!)

Thanks for submitting! Can't wait to see merge that change is made.

Note: don't open a new PR, just commit changes to this current thread + send a comment when changes have been made!

@acornitum acornitum removed the needs review needs acon to check over it , ,,,, label Feb 2, 2025
@sssyntax
Copy link
Contributor Author

sssyntax commented Feb 3, 2025

I love this!! The animations are absolutely adorable. I love the tiny details you put in - from the flicking of the tail, to the cat flicking its ears when getting rubbed on its head - it's so cute.

I really want to merge this, but there's one thing that I want changed - the actual hackapet only has 3 buttons, so would it be possible for you to remap the key presses to only 3 buttons? (What a lot of people do is let two buttons be an action in order to fit it all in!)

Thanks for submitting! Can't wait to see merge that change is made.

Note: don't open a new PR, just commit changes to this current thread + send a comment when changes have been made!

oh alright! i'll do that.

@sssyntax
Copy link
Contributor Author

i've added my changes, you can take a look now @acornitum

@acornitum acornitum added the needs review needs acon to check over it , ,,,, label Feb 13, 2025
@acornitum
Copy link
Contributor

thank you!!! the cat is sooo cute.

going to merge this - fill out the form here: https://forms.hackclub.com/t/isDdJtrnrvus

@acornitum acornitum merged commit 741637b into hackclub:main Feb 14, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review needs acon to check over it , ,,,,
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants