Alert user to reload page on failed asset loading #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This doesn't seem to work if a load is hanging. I.E. if the loading gets stuck but the page is still in the "loading" state, the alert won't trigger until you click the stop loading button. |
|
@camdan-me which browser are you in? This worked for me on ff-dev and latest chrome on macos. what's the "stop loading" button? |
|
I'm on Edge. And I'm not sure what the word for the button would be, but it's the "x" that the reload button turns in to when a page is loading. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second part of #475 – if we do fail to load an asset, let's alert the user and ask them to refresh. Next step is to actually introduce retries to get these assets loading correctly!