Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change finally to else #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

change finally to else #33

wants to merge 1 commit into from

Conversation

rule88
Copy link

@rule88 rule88 commented Dec 23, 2020

When returning a value in finally, the potentially raised error in the except is never handled: (https://stackoverflow.com/questions/53435114/python-exception-not-raised-if-finally-returns-value).

To achieve what apparently was aimed for, the else block should be used (which does makes sense when reading the uploaded log message "f'Uploaded {file} to {self.remote_path}").

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant