Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ui3 #919

Open
wants to merge 7 commits into
base: dev
Choose a base branch
from
Open

Feature/ui3 #919

wants to merge 7 commits into from

Conversation

ThomasJGabrielsen
Copy link
Contributor

Replace Main menu UI with more modern alternative, and expand on the menu scene with new models:
Screenshot 2024-12-11 205221

# Conflicts:
#	Assets/Prefabs/UI/Menus/MenuCanvas.prefab
#	Assets/Scenes/Menu.unity
Adjusted scale and positioning of UI elements
Forced a vector to be a value in case random returns (0,0) in TilingCowboys.cs
Commented out camera moving to options in MainMenuMoveCamera.cs
Added comments to TilingCowboys.cs
Copy link
Contributor

@toberge toberge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall very nice, especially

  • cool new buttons that have better transitions (could perhaps use a background in some cases but ehhh)
  • nice that we also have the sliding cowbot backdrop for the descriptions
  • torii gate

However, I found a few issues:

  • keybind and look options still have black text
  • keybinding reset button looks a little scuffed
    image
  • cowbot background no longer moves on the loading screen :/
  • queue meny looks weird w/o steam connection, and keyboard navigation breaks when you press down from the back button:
    image
  • Pressing down from Three Strikes jumps straight to the back button in local play and friends only menu:
    image
  • In the queue menu, it doesn't even move from that button:
    image
  • Custom gamemode menu doesn't have the fancy new background but white text:
    image
  • Pause menu has different text size for the two buttons
  • and sometimes I need to press the movement key twice to actually move from button to button, so something seems to be mildly borked there?

LeanTween.sequence()
.append(LeanTween.rotateY(mainMenuCamera.gameObject, 10, cameraSpeed).setEaseInOutQuart());
//LeanTween.sequence()
// .append(LeanTween.rotateY(mainMenuCamera.gameObject, 10, cameraSpeed).setEaseInOutQuart());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

muh settings view -_-




// Start is called before the first frame update
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls remove standard comments here :))))


public class TilingCowboys : MonoBehaviour
{
[SerializeField] private RawImage cowboys;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo, should be cowbots >:)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This material is used for boxes and platforms in The Pit, please create a new material instead.

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one can be reverted

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure where this is used, but I think there are gradient options on most things that can apply an effect like this without having to rely on a texture

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the background texture for the new buttons I think, so not really an issue there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants