Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Drive Form Validation #1796

Open
wants to merge 3 commits into
base: development
Choose a base branch
from

Conversation

nora-zajzon
Copy link
Member

@nora-zajzon nora-zajzon commented Oct 16, 2024

Fixes #1369

What changes did you make and why did you make them ?

  • Made the Google Drive URL required
  • Added validation for url to make sure it is a valid google drive link

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied Screenshot 2024-10-16 at 11 31 14 AM
Visuals after changes are applied Screenshot 2024-10-16 at 11 29 09 AM Screenshot 2024-10-16 at 11 29 17 AM

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b nora-zajzon-GoogleDriveValidation development
git pull https://github.com/nora-zajzon/VRMS.git GoogleDriveValidation

@nora-zajzon
Copy link
Member Author

Ignore the two test pushes. I was receiving help on git usage in Mondays meeting

@pluto-bell pluto-bell self-requested a review October 28, 2024 18:48
Copy link
Member

@pluto-bell pluto-bell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work *~ Everything looks good to me and the Google Drive URL validation works as expected.

@pluto-bell pluto-bell added the ready for dev lead Add to issue when dev lead needs to take some action label Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for dev lead Add to issue when dev lead needs to take some action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Form Validation - Google Drive URL
2 participants