Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update and add dependencies #240

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Update and add dependencies #240

wants to merge 3 commits into from

Conversation

k3KAW8Pnf7mkmdSMPHz27
Copy link
Collaborator

  1. Updates ESLint, Prettier, and Jest dependencies
  2. Changes som ESLint rules
  3. Fixes some ESLint complaints

plocket
plocket reviewed Dec 24, 2021
View reviewed changes
Copy link

@plocket plocket left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some good cleanup. I don't know enough about the environment to understand exactly what's going on with jest, though. You've added it to api/package.json, but removed it from api/setupTests.js.

I tried running yarn test in "api", but I got errors and couldn't run it, so I wasn't able to see more about what was going on there. That also meant I couldn't confirm that the updates to the various libraries didn't break anything, but other than jest it seems to be linting and such, so I'm not super concerned.

If you're sure all that is as it should be, the PR looks good to me. Let me know and I'll approve.

@k3KAW8Pnf7mkmdSMPHz27
Copy link
Collaborator Author

For now, this PR is superseded by experiments with xo-linter. We'll see which seems more suitable (dealing with eslint rules manually or going with xo-linter presets)

@k3KAW8Pnf7mkmdSMPHz27 k3KAW8Pnf7mkmdSMPHz27 marked this pull request as draft April 16, 2022 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plocket plocket plocket left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@k3KAW8Pnf7mkmdSMPHz27 @plocket