Resolve CodeQL Alert 41: Missing variable declaration

[roslynwythe]

Prerequisite

1. Be a member of Hack for LA. (There are no fees to join.) If you have not joined yet, please follow the steps on our Getting Started page.
2. Before you claim or start working on an issue, please make sure you have read our How to Contribute to Hack for LA Guide.

Overview

As developers. we need to analyze CodeQL query alert 41 and to either recommend dismissal of the alert or update the code to resolve the alert.

Action Items

• DO NOT DISMISS ANY ALERTS. Dismissal of alerts should be done by dev leads only after review of the recommendation
• Browse to the link in the next Action Item and read the contents. Click "See More" to view Recommendations, Examples and References.
• https://github.com/hackforla/website/security/code-scanning/41
• In a comment in this issue, add your analysis and recommendations. The recommendation can be one of the following: dismiss as test, dismiss as false positive, dismiss as won't fix, or update code. An example of a 'false positive' is a report of a JavaScript syntax error that is caused by markdown or liquid symbols such as --- or {%.
• Apply the label ready for dev lead then move the issue to Questions/In Review
• If the recommendation is to update code:
  • create an issue branch and proceed with the code update
  • Using docker, test /design-system/components/button.html locally and confirm that the script behaves identically to the existing web page: Design System Components - Buttons page
  • proceed with pull request in the usual manner

For merge team/dev lead

• If recommendation to dismiss is approved, dismiss the alert with a comment, then close the issue as completed.
• When this issue is closed please check off the dependency (under "Analysis Issues") in Epic: Manage CodeQL deployment #5005. If all analysis issues are closed, close Epic: Manage CodeQL deployment #5005 as completed.

Resources/Instructions

• GitHub CodeQL documentation
• Design System Components - Buttons page
• This issue is part of Epic: Manage CodeQL deployment #5005

[github-actions]

Hi @jphamtv, thank you for taking up this issue! Hfla appreciates you :)

Do let fellow developers know about your:-
i. Availability: (When are you available to work on the issue/answer questions other programmers might have about your issue?)
ii. ETA: (When do you expect this issue to be completed?)

You're awesome!

P.S. - You may not take up another issue until this issue gets merged (or closed). Thanks again :)

[jphamtv]

Availability for this week: Monday-Friday 12–2 PM, 8–10 PM (PST)
My estimated ETA for completing this issue: 11/29/23

[jphamtv]

The code alert was triggered because the 'i' variable in the for loop is not declared, making it a global variable by default.

I suggest updating the code to declare the 'i' variable within the loop. This will make it block-scoped and help avoid any future bugs or alerts.

• I've created an issue branch to update the code. Pull request: Declare Loop Variable in primaryOnDarkHandler Function #5940