Declare Loop Variable in primaryOnDarkHandler Function

[jphamtv]

Fixes #5706

What changes did you make?

• Declared the loop variable in primaryOnDarkHandler on line 14 in the assets/js/design-system.js file

Why did you make the changes (we will use this info to test)?

• To resolve the CodeQL alert

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

Visuals after changes are applied

Before and after screenshots from the local browser were provided to confirm script behaves identically to the existing web page: https://www.hackforla.org/design-system/components/button.html

[github-actions]

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b jphamtv-fix-loop-variable-scope-5706 gh-pages
git pull https://github.com/jphamtv/website.git fix-loop-variable-scope-5706

---

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/jphamtv/website/blob/fix-loop-variable-scope-5706/CONTRIBUTING.md  

[agutiernc]

Availability: 11/29 - after 8pm
Review ETA: 11/29 - EOD

[Thinking-Panda]

Availability: weekdays
ETA: 11/29

[Thinking-Panda]

@jphamtv Thank you for working on this issue. Merge branches look good. When locally visited, website works identical to the published website. Well done!

[agutiernc]

Great work resolving this issue @jphamtv. Everything looks good as it has the correct fixed link, branches, and the variable was declared properly. The functionality of the website is the same. Thanks for contributing!