Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Leadership Profile (Arpita Pandya) in _projects/luckyparking.md #5943

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

rankdjr
Copy link
Member

@rankdjr rankdjr commented Nov 29, 2023

Fixes #5797

What changes did you make?

  • Removed leadership profile information for Arpita Pandya from _projects/luckyparking.md

Why did you make the changes (we will use this info to test)?

  • To keep project information up to date

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

before

Visuals after changes are applied

after

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b rankdjr-update-luckyparking-5797 gh-pages
git pull https://github.com/rankdjr/hflawebsite.git update-luckyparking-5797

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/rankdjr/website/blob/update-luckyparking-5797/CONTRIBUTING.md  

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Nov 29, 2023
@jphamtv jphamtv self-requested a review November 29, 2023 05:16
@jphamtv
Copy link
Member

jphamtv commented Nov 29, 2023

Availability: Monday-Friday 12–2 PM, 8–10 PM (PST)
My estimated ETA for completing this issue: 11/29/23

Copy link
Member

@jphamtv jphamtv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rankdjr,
The pull request is linked to the issue correctly. Changes in the source code are applicable and clean. The update looks good in the browser. PR is approved, awesome job!

@LRenDO LRenDO self-requested a review November 29, 2023 21:28
Copy link
Member

@LRenDO LRenDO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rankdjr!
Great job with this pull request!

  • The branching was done correctly
  • Issue number was listed
  • The PR title is descriptive of the changes
  • Changes were made correctly in the code
  • Changes appear correctly on the site. Aripita has been removed.
  • Relevant images were included to show visual changes
  • The PR request clearly states what was updated
  • The PR request states why the changes are being made

Again, nice work and thanks for taking the time to contribute to the website!

@LRenDO LRenDO merged commit c9192a7 into hackforla:gh-pages Nov 29, 2023
10 checks passed
@rankdjr rankdjr deleted the update-luckyparking-5797 branch December 8, 2023 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Project Profile: Lucky Parking (Remove Arpita Pandya)
3 participants