Removes CFA from about page #5945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL: |
github-actions
bot
added
good first issue
jphamtv
requested review from
akibrhast and
jphamtv
and removed request for
akibrhast
|
Availability: Monday-Friday 12–2 PM, 8–10 PM (PST) |
LRenDO
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
Hi @djbradleyii!
Great job with this pull request!
- The branching was done correctly
- Issue number was listed
- The PR title is descriptive of the changes
- Changes were made correctly in the code
- Changes appear correctly on the site. The CFA logo has been removed from the about page.
- Relevant images were included to show visual changes
- The PR request clearly states what was updated
- The PR request states why the changes are being made
Again, nice work and thanks for taking the time to contribute to the website!
jphamtv
approved these changes
Nov 30, 2023
There was a problem hiding this comment.
Hey @djbradleyii,
The pull request is linked to the issue correctly. Changes in the source code are applicable and clean. The update looks good in the browser. PR is approved, great work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5511
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied