Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removes 1password from tech work experience #5946

Merged
merged 1 commit into from
Nov 30, 2023
Merged

removes 1password from tech work experience #5946

merged 1 commit into from
Nov 30, 2023

Conversation

sornekian
Copy link
Member

Fixes #5681

What changes did you make?

  • Removed 1Password from the tools section of tech-work-experience

Why did you make the changes (we will use this info to test)?

  • To update the tools section of the Project Check Page and Tech Work Experience Project Page

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied before1 before2
Visuals after changes are applied after1

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b sornekian-removes-1password-5681 gh-pages
git pull https://github.com/sornekian/website.git removes-1password-5681

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/sornekian/website/blob/removes-1password-5681/CONTRIBUTING.md  

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Nov 29, 2023
Copy link
Member

@LRenDO LRenDO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sornekian!
Great job with this pull request!

  • The branching was done correctly
  • Issue number was listed
  • The PR title is descriptive of the changes
  • Changes were made correctly in the code
  • Changes appear correctly on the site. 1Password has been removed from Tech Work Experience.
  • Relevant images were included to show visual changes
  • The PR request clearly states what was updated
  • The PR request states why the changes are being made

Again, nice work and thanks for taking the time to contribute to the website!

@LRenDO LRenDO merged commit 1ccfd94 into hackforla:gh-pages Nov 30, 2023
@sornekian sornekian deleted the removes-1password-5681 branch December 13, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove '1Password' From Tools Data in tech-work-experience.md
2 participants