Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed Diedrich Chavarria #5951

Merged
merged 1 commit into from
Dec 2, 2023

Conversation

heejung-hong
Copy link
Member

Fixes #5798

What changes did you make?

  • Removed Diedrich Chavarria from Lucky Parking project.

Why did you make the changes (we will use this info to test)?

  • To keep Hack for LA website up to date with correct information.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

Screenshot 2023-11-30 at 1 37 06 PM

Visuals after changes are applied

Screenshot 2023-11-30 at 1 37 48 PM

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Nov 30, 2023
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b heejung-hong-lucky-parking-5798 gh-pages
git pull https://github.com/heejung-hong/website.git lucky-parking-5798

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/heejung-hong/website/blob/lucky-parking-5798/CONTRIBUTING.md  

@jphamtv jphamtv self-requested a review December 1, 2023 05:28
@jphamtv
Copy link
Member

jphamtv commented Dec 1, 2023

Availability: Monday-Friday 12–2 PM, 8–10 PM (PST)
Estimated ETA: 12/01/23

Copy link
Member

@jphamtv jphamtv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @heejung-hong,
Good job on resolving the issue. You used the right to/from branches and linked the issue correctly. The summary is clear, and the screenshots accurately display the changes. The source code is clean and the update checks out in the browser.

@kwangric kwangric self-requested a review December 2, 2023 15:12
@kwangric
Copy link
Member

kwangric commented Dec 2, 2023

ETA: EOD 12/2
Availability: Evening 12/2

Copy link
Member

@kwangric kwangric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Branches are set up correctly. The requested person was removed from the Lucky Parking team, and everything looks good in Docker. The PR also includes screenshots of before and after. Great work!

@kwangric kwangric merged commit da49da6 into hackforla:gh-pages Dec 2, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Project Profile: Lucky Parking (Remove Diedrich Chavarria)
3 participants