-
-
Notifications
You must be signed in to change notification settings - Fork 794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated contributing.md 3.1.b VI #5955
Updated contributing.md 3.1.b VI #5955
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:
|
ETA: 12/2 15:00 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@james-aguirre Thank you for taking up this issue!😆 You correctly put a linked issue in the pull request, you used correct branches and you deleted requested section from CONTRIBUTING.md.🙌🏻
I have one small request, original issue requests you to put comment for reviewer under "Why did you make the changes" section. Please follow this section and leave a link for a reviewer.
@Tomomi-K1 Hi Tomomi, PR has been updated to include a link to the test server. Thanks for the review! |
@james-aguirre Thank you for updating a pull request.😊 I might be being too picky about this, but as the issue instruction said, could you put, "For Reviewers: Do not review changes locally, rather, review changes at [REPLACE WITH TEST URL]" under "Why did you make changes", not under "What changes did you make?" so that it is obvious for reviewers where to check at one glance. |
ETA: 12/7/23 |
Hi @james-aguirre thank you for including the test URL for the convenience of reviewers. To avoid confusion, please remove the square brackets surrounding the test URL. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@james-aguirre Please check @roslynwythe comment and remove [ ]. Thank you for updating it several times!!😊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@james-aguirre Great job! Thank you for updating the pull request several times!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @james-aguirre Great job on the PR! You have the correct branches, a link back to the original issue, a succinct description of the changes you made and why, appropriate screenshots, and your code edits address only what needs to change. Thanks for working with @Tomomi-K1 and thanks for improving the CONTRIBUTING.md
document.
Fixes #5696
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied