Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated contributing.md 3.1.b VI #5955

Conversation

james-aguirre
Copy link
Member

@james-aguirre james-aguirre commented Dec 2, 2023

Fixes #5696

What changes did you make?

  • Updated text in contributing.md documentation section 3.1.b VI to remove duplicate statements.

Why did you make the changes (we will use this info to test)?

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied Screenshot 2023-12-01 at 5 06 00 PM
Visuals after changes are applied Screenshot 2023-12-01 at 5 05 11 PM

Copy link

github-actions bot commented Dec 2, 2023

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b james-aguirre-update-contributing-section-31b-5696 gh-pages
git pull https://github.com/james-aguirre/website.git update-contributing-section-31b-5696

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/james-aguirre/website/blob/update-contributing-section-31b-5696/CONTRIBUTING.md  

@github-actions github-actions bot added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Feature: Wiki Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.5pt Can be done in 3 hours or less labels Dec 2, 2023
@Tomomi-K1 Tomomi-K1 self-requested a review December 2, 2023 21:40
@Tomomi-K1
Copy link
Member

ETA: 12/2 15:00
Availability: Weekday 12-5pm

Copy link
Member

@Tomomi-K1 Tomomi-K1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@james-aguirre Thank you for taking up this issue!😆 You correctly put a linked issue in the pull request, you used correct branches and you deleted requested section from CONTRIBUTING.md.🙌🏻

I have one small request, original issue requests you to put comment for reviewer under "Why did you make the changes" section. Please follow this section and leave a link for a reviewer.
image

@james-aguirre
Copy link
Member Author

@Tomomi-K1 Hi Tomomi, PR has been updated to include a link to the test server. Thanks for the review!
Screenshot 2023-12-02 at 6 05 00 PM

@Tomomi-K1
Copy link
Member

@james-aguirre Thank you for updating a pull request.😊 I might be being too picky about this, but as the issue instruction said, could you put, "For Reviewers: Do not review changes locally, rather, review changes at [REPLACE WITH TEST URL]" under "Why did you make changes", not under "What changes did you make?" so that it is obvious for reviewers where to check at one glance.
Thank you for your help! And After you update, please click button to request re-review as shown below. If you have any questions, let me know I'm on slack with same first name.
image

@pdimaano pdimaano self-requested a review December 4, 2023 17:16
@pdimaano
Copy link
Member

pdimaano commented Dec 4, 2023

ETA: 12/7/23
Availability: Weekday evenings

@roslynwythe
Copy link
Member

Hi @james-aguirre thank you for including the test URL for the convenience of reviewers. To avoid confusion, please remove the square brackets surrounding the test URL. Thanks!

Copy link
Member

@Tomomi-K1 Tomomi-K1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@james-aguirre Please check @roslynwythe comment and remove [ ]. Thank you for updating it several times!!😊

Copy link
Member

@Tomomi-K1 Tomomi-K1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@james-aguirre Great job! Thank you for updating the pull request several times!!

@t-will-gillis t-will-gillis self-requested a review December 18, 2023 03:42
Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @james-aguirre Great job on the PR! You have the correct branches, a link back to the original issue, a succinct description of the changes you made and why, appropriate screenshots, and your code edits address only what needs to change. Thanks for working with @Tomomi-K1 and thanks for improving the CONTRIBUTING.md document.

@t-will-gillis t-will-gillis merged commit 848ff3b into hackforla:gh-pages Dec 18, 2023
15 checks passed
jphamtv pushed a commit to jphamtv/hackforla-website that referenced this pull request Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Wiki role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update CONTRIBUTING.md Section 3.1.b vi
5 participants