Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cspell.json with term "Undebate" #5957

Merged

Conversation

dimiprousalis
Copy link
Member

@dimiprousalis dimiprousalis commented Dec 4, 2023

Fixes #5685

What changes did you make?

  • Updated cspell.json with false positive term "Undebate"

Why did you make the changes (we will use this info to test)?

  • To update the Code Spell Checker configuration file with false positive term so that it is no longer marked as errors

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

  • No visual changes required

Copy link

github-actions bot commented Dec 4, 2023

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b dimiprousalis-update-cspell-undebate-5685 gh-pages
git pull https://github.com/dimiprousalis/website.git update-cspell-undebate-5685

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/dimiprousalis/website/blob/update-cspell-undebate-5685/CONTRIBUTING.md  

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers size: 0.25pt Can be done in 0.5 to 1.5 hours feature: spelling labels Dec 4, 2023
@freaky4wrld freaky4wrld self-requested a review December 6, 2023 05:09
@freaky4wrld
Copy link
Member

Availability: Evenings
ETA: EOD 12/6/23

@freaky4wrld
Copy link
Member

@dimiprousalis all the work assigned to you in the issue is done correctly and look good on testing on local environment, I can approve it, just some minor changes to the above comment, clear out the extra bullets by clicking on the three dots and making use of edit option, then remove those extra dashes - also in the visual changes section remove the after and before column instead write No visual changes required and all set.

Great work with the issue, just few changes more and I'll approve this.

@dimiprousalis
Copy link
Member Author

@dimiprousalis all the work assigned to you in the issue is done correctly and look good on testing on local environment, I can approve it, just some minor changes to the above comment, clear out the extra bullets by clicking on the three dots and making use of edit option, then remove those extra dashes - also in the visual changes section remove the after and before column instead write No visual changes required and all set.

Great work with the issue, just few changes more and I'll approve this.

Thank you for the review @freaky4wrld! I've updated the comment.

Copy link
Member

@freaky4wrld freaky4wrld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dimiprousalis thanks for taking up the issue and making the suggested edits, I approve this. Great work there!!!

@heejung-hong heejung-hong self-requested a review December 7, 2023 22:48
@heejung-hong
Copy link
Member

Availability: Weekdays After 12pm
ETA: EOD 12/07/23

Copy link
Member

@heejung-hong heejung-hong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @dimiprousalis,

The branches are correct and the issue is linked.
The correct file was changed with the correct information.

In my VS code, the comma after "Undebate" is showing an error sign but the spell checker is indicating the spelling error in FOLA and LBGTQI, so the spell checker appears to be working.

Good job!

@t-will-gillis t-will-gillis merged commit 1768616 into hackforla:gh-pages Dec 8, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature: spelling good first issue Good for newcomers role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update cspell.json with false positive term "Undebate"
4 participants