Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete .github/workflows/schedule-monthly-PREV.yml #5967

Merged

Conversation

t-will-gillis
Copy link
Member

Delete obsolete file, functionality incorporated in #5467

Fixes #5966

What changes did you make?

  • Delete schedule-monthly-PREV.yml

Why did you make the changes (we will use this info to test)?

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes

Delete obsolete file, functionality incorporated in hackforla#5467
Copy link

github-actions bot commented Dec 5, 2023

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b t-will-gillis-delete-obs-file-5966 gh-pages
git pull https://github.com/t-will-gillis/website.git delete-obs-file-5966

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/t-will-gillis/website/blob/delete-obs-file-5966/CONTRIBUTING.md  

@github-actions github-actions bot added Bug Something isn't working role: back end/devOps Tasks for back-end developers time sensitive Needs to be worked on by a particular timeframe Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms size: 8pt Can be done in 31-48 hours size: 0.25pt Can be done in 0.5 to 1.5 hours Complexity: Extra Large labels Dec 5, 2023
@t-will-gillis t-will-gillis removed Bug Something isn't working size: 8pt Can be done in 31-48 hours Complexity: Extra Large time sensitive Needs to be worked on by a particular timeframe labels Dec 5, 2023
@jphamtv jphamtv self-requested a review December 6, 2023 06:23
@jphamtv
Copy link
Member

jphamtv commented Dec 6, 2023

Availability: Monday-Friday 12–2 PM, 8–10 PM (PST)
Estimated ETA: 12/06/23

Copy link
Member

@jphamtv jphamtv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @t-will-gillis, the from/to branches are correctly set up, and the issue link is properly included. I checked out your branch and confirmed that the schedule-monthly-PREV.yml file has been successfully deleted from the .github/workflows folder as intended. Everything looks good to me!

@freaky4wrld freaky4wrld self-requested a review December 6, 2023 14:20
Copy link
Member

@freaky4wrld freaky4wrld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@t-will-gillis it looks the deletion you performed is done correctly and the to/from branch looks good, and there's no visual changes, the file schedule-monthly-PREV.yml is done correctly.
Everything looks fine and I approve this!!

@t-will-gillis
Copy link
Member Author

Thanks @jphamtv & @freaky4wrld !

@t-will-gillis t-will-gillis merged commit aa3d803 into hackforla:gh-pages Dec 6, 2023
10 checks passed
@t-will-gillis t-will-gillis deleted the delete-obs-file-5966 branch December 6, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms role: back end/devOps Tasks for back-end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete obsolete file schedule-monthly-PREV Fix bug that prevents GHA "Schedule Monthly" from running
3 participants