Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored CSS so icon-slack.svg can use various colors #6003

Conversation

piecanoe
Copy link
Member

Fixes #5819

What changes did you make?

  • added ":not(div.resource-img *" to .icon {}

Why did you make the changes (we will use this info to test)?

  • This will allow the icon-slack.svg icons to be displayed in resource cards with their original colors

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

image

Visuals after changes are applied

image

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b piecanoe-refactor-css-icon-slack.svg-for-colors-5819 gh-pages
git pull https://github.com/piecanoe/website.git refactor-css-icon-slack.svg-for-colors-5819

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/piecanoe/website/blob/refactor-css-icon-slack.svg-for-colors-5819/CONTRIBUTING.md  

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers Feature: Refactor CSS Page is working fine - CSS needs changes to become consistent with other pages size: 0.25pt Can be done in 0.5 to 1.5 hours labels Dec 12, 2023
@colin-macrae colin-macrae self-requested a review December 13, 2023 03:23
@colin-macrae
Copy link
Member

Review ETA: 12/13/23
Availability: 2+ hrs on 12/13, plus 4+ other hrs this week

@MattChau01 MattChau01 self-requested a review December 13, 2023 06:22
@MattChau01
Copy link
Member

ETA: 12/14
Availability: Weekday evenings

Copy link
Member

@colin-macrae colin-macrae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @piecanoe - This looks good, except I don't believe any extra code was supposed to be deleted. That is, the original lines 1-4 should still be there, and only lines 5-10 should be replaced, according to the issue's instructions. Please do let me know if you think I've overlooked anything. Thanks! 😁

@piecanoe
Copy link
Member Author

Hi Colin, thanks for catching this. I will correct this and resubmit.

@piecanoe
Copy link
Member Author

Fixes #5819

What changes did you make?

  • Added back the original 1-4 lines:

.svg-sprites {
display: none;
}

Why did you make the changes (we will use this info to test)?

  • This was incorrectly removed on the first push

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

image

Visuals after changes are applied

image

Copy link
Member

@MattChau01 MattChau01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @piecanoe, great work on the PR and responding to @colin-macrae's change request! For future references, you can remove the section for screenshots if the issue doesn't have any frontend/visual changes.

Copy link
Member

@colin-macrae colin-macrae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@piecanoe great job, and thanks @MattChau01. The mistaken deletions were re-added and the changes approved.

@kwangric kwangric merged commit 7b69784 into hackforla:gh-pages Dec 15, 2023
3 checks passed
jphamtv pushed a commit to jphamtv/hackforla-website that referenced this pull request Dec 31, 2023
* Refactored CSS so icon-slack.svg can use various colors

* Re-add lines 1-4 from original code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature: Refactor CSS Page is working fine - CSS needs changes to become consistent with other pages good first issue Good for newcomers role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor CSS so icon-slack.svg can be reused with various colors
4 participants