-
-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored CSS so icon-slack.svg can use various colors #6003
Refactored CSS so icon-slack.svg can use various colors #6003
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:
|
Review ETA: 12/13/23 |
ETA: 12/14 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @piecanoe - This looks good, except I don't believe any extra code was supposed to be deleted. That is, the original lines 1-4 should still be there, and only lines 5-10 should be replaced, according to the issue's instructions. Please do let me know if you think I've overlooked anything. Thanks! 😁
Hi Colin, thanks for catching this. I will correct this and resubmit. |
Fixes #5819 What changes did you make?
.svg-sprites { Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The branch is going into the correct branch
gh-pages
. ✅ - The original issue Refactor CSS so
icon-slack.svg
can be reused with various colors #5819 was properly referenced. ✅ - Per the instructions on the original issue, the specified lines of code were properly updated. ✅
Hi @piecanoe, great work on the PR and responding to @colin-macrae's change request! For future references, you can remove the section for screenshots if the issue doesn't have any frontend/visual changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@piecanoe great job, and thanks @MattChau01. The mistaken deletions were re-added and the changes approved.
- The branch is going into the correct branch gh-pages. ✅
- The original issue Refactor CSS so
icon-slack.svg
can be reused with various colors #5819 was properly referenced. ✅ - Per the instructions on the original issue, the specified lines of code were properly updated. ✅
* Refactored CSS so icon-slack.svg can use various colors * Re-add lines 1-4 from original code
Fixes #5819
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied