Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added 'test/' to ignorePaths array in cspell.json #6004

Merged

Conversation

naveenmallemala5
Copy link
Member

@naveenmallemala5 naveenmallemala5 commented Dec 13, 2023

Fixes #5848

What changes did you make?

  • Added 'test/' to ignorePaths array in cspell.json

Why did you make the changes (we will use this info to test)?

  • To ignore files in the 'test/' path for spell checking.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Visuals before changes are applied

image

Visuals after changes are applied

image

Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b naveenmallemala5-add-test-ignorepaths-5848 gh-pages
git pull https://github.com/naveenmallemala5/HLA_website.git add-test-ignorepaths-5848

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/naveenmallemala5/website/blob/add-test-ignorepaths-5848/CONTRIBUTING.md  

@kwangric
Copy link
Member

Hey @naveenmallemala5! Looks like the PR is currently linked to the wrong issue (it's currently pointing to itself). Can you edit the first line so it references the correct issue number (#5848)?

@github-actions github-actions bot added role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers To Update ! No update has been provided Complexity: Small Take this type of issues after the successful merge of your second good first issue size: 0.5pt Can be done in 3 hours or less feature: spelling labels Dec 15, 2023
@naveenmallemala5
Copy link
Member Author

Hi @kwangric, I've updated the first line with the correct issue number (#5848), Please review, merge and close the issue. Thank you !

@t-will-gillis
Copy link
Member

Hey @colin-macrae and @naveenmallemala5 I will leave this message on both of your PRs. Since you are both waiting for your PRs to be reviewed- you could consider reviewing each other's in the meantime and then when they are ready one of us will be available to merge them. Your respective PRs are #6006 and #6004.

@colin-macrae colin-macrae self-requested a review December 18, 2023 21:46
Copy link
Member

@colin-macrae colin-macrae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@naveenmallemala5, great job.

  • The branch is going into the correct branch gh-pages. ✅
  • The original issue [issue with #number] was properly referenced. ✅
  • Per the instructions on the original issue, the correct code was added to cspell.json. ✅

@freaky4wrld freaky4wrld self-requested a review December 20, 2023 03:40
@freaky4wrld
Copy link
Member

Availability: Evenings
ETA: EOD 12/20

Copy link
Member

@freaky4wrld freaky4wrld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @naveenmallemala5 thanks for taking up the issue, the changes suggested in the linked issue are done correctly, the to/from branch looks great.

I approve this PR.....

@kwangric kwangric merged commit 121c485 into hackforla:gh-pages Dec 20, 2023
11 of 12 checks passed
jphamtv pushed a commit to jphamtv/hackforla-website that referenced this pull request Dec 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Complexity: Small Take this type of issues after the successful merge of your second good first issue feature: spelling role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.5pt Can be done in 3 hours or less To Update ! No update has been provided
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "test/" to "ignorePaths" array in cspell.json
5 participants