-
-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added 'test/' to ignorePaths array in cspell.json #6004
Added 'test/' to ignorePaths array in cspell.json #6004
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:
|
Hey @naveenmallemala5! Looks like the PR is currently linked to the wrong issue (it's currently pointing to itself). Can you edit the first line so it references the correct issue number (#5848)? |
Hey @colin-macrae and @naveenmallemala5 I will leave this message on both of your PRs. Since you are both waiting for your PRs to be reviewed- you could consider reviewing each other's in the meantime and then when they are ready one of us will be available to merge them. Your respective PRs are #6006 and #6004. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@naveenmallemala5, great job.
- The branch is going into the correct branch gh-pages. ✅
- The original issue [issue with #number] was properly referenced. ✅
- Per the instructions on the original issue, the correct code was added to cspell.json. ✅
Availability: Evenings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @naveenmallemala5 thanks for taking up the issue, the changes suggested in the linked issue are done correctly, the to/from branch looks great.
I approve this PR.....
Co-authored-by: Naveen Mallemala <[email protected]>
Fixes #5848
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Visuals before changes are applied
Visuals after changes are applied