Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Project Profile: Home Unite Us Remove Flora Osmond (#7480) #7874

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

rogerioduenas
Copy link
Member

Fixes #7480

What changes did you make?

  • Remove Flora Osmond profile to leadership variable in _projects/home-unite-us.md

Why did you make the changes (we will use this info to test)?

  • We need to keep project information up to date so that visitors to the website can find accurate information.

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied

before

Visuals after changes are applied

after

Copy link

github-actions bot commented Feb 3, 2025

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b rogerioduenas-upp_7478 gh-pages
git pull https://github.com/rogerioduenas/HfLA_website.git upp_7478

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Feb 3, 2025
@NolaDodd NolaDodd self-requested a review February 5, 2025 00:35
@NolaDodd
Copy link
Member

NolaDodd commented Feb 5, 2025

Review ETA: 5 PM 2/4/25
Availability: 5-8 PM Tuesday

Copy link
Member

@NolaDodd NolaDodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Good job with this issue!

The only thing I noticed is that the branch numbering is off and the naming could be more descriptive. Your branch issue number is 7874, but you put in your branch name as 7478. Make sure the numbers match in the future.

Also, you named your branch issue name simply as upp_7874. I think it would be more helpful in the future to have a more descriptive branch name, for example: huu-remove-flora-osmond-7874.

Everything else seems to be good though!

  • The commit is going to the correct location (hackforla:gh-pages)
  • The commit from is from the collaborator
  • The issue is correctly linked
  • The branch correctly addresses and fixes everything in the linked issue.
  • The pull request screenshots are accurate.

Great job!

@rogerioduenas
Copy link
Member Author

Hey @NolaDodd,

Thanks for reviewing my pull request! I really appreciate the feedback. I'll make sure to use the correct issue number and a more descriptive branch name in my next PR.

Thanks again!

Copy link

github-actions bot commented Feb 5, 2025

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b rogerioduenas-upp_7478 gh-pages
git pull https://github.com/rogerioduenas/HfLA_website.git upp_7478

Copy link
Member

@LRenDO LRenDO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rogerioduenas!
Great job with this pull request!

  • The branching was done correctly
  • Issue number was listed
  • The PR title is descriptive of the changes
  • Changes were made correctly in the code
  • Changes appear correctly on the site - Flora Osmond was removed from the Home Unite Us page
  • Relevant images were included to show visual changes
  • The PR request clearly states what was updated

Again, great work and thanks for taking the time to contribute to the website!

@LRenDO LRenDO merged commit 91c20fd into hackforla:gh-pages Feb 6, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
Development

Successfully merging this pull request may close these issues.

Update Project Profile: Home Unite Us Remove Flora Osmond
3 participants