-
-
Notifications
You must be signed in to change notification settings - Fork 792
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Project Profile: Home Unite Us Remove Flora Osmond (#7480) #7874
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
Review ETA: 5 PM 2/4/25 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! Good job with this issue!
The only thing I noticed is that the branch numbering is off and the naming could be more descriptive. Your branch issue number is 7874, but you put in your branch name as 7478. Make sure the numbers match in the future.
Also, you named your branch issue name simply as upp_7874. I think it would be more helpful in the future to have a more descriptive branch name, for example: huu-remove-flora-osmond-7874.
Everything else seems to be good though!
- The commit is going to the correct location (hackforla:gh-pages)
- The commit from is from the collaborator
- The issue is correctly linked
- The branch correctly addresses and fixes everything in the linked issue.
- The pull request screenshots are accurate.
Great job!
Hey @NolaDodd, Thanks for reviewing my pull request! I really appreciate the feedback. I'll make sure to use the correct issue number and a more descriptive branch name in my next PR. Thanks again! |
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @rogerioduenas!
Great job with this pull request!
- The branching was done correctly
- Issue number was listed
- The PR title is descriptive of the changes
- Changes were made correctly in the code
- Changes appear correctly on the site - Flora Osmond was removed from the Home Unite Us page
- Relevant images were included to show visual changes
- The PR request clearly states what was updated
Again, great work and thanks for taking the time to contribute to the website!
Fixes #7480
What changes did you make?
_projects/home-unite-us.md
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
Visuals after changes are applied