Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update TDM Calc project profile - remove Jane He #7898

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from

Conversation

gmgonzal
Copy link
Member

@gmgonzal gmgonzal commented Feb 6, 2025

Fixes #7652

What changes did you make?

  • Removed Jane He from leadership variable in _projects/tdm-calculator.md file

Why did you make the changes (we will use this info to test)?

  • To keep the TDM Calculator project info up to date.

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Visuals before changes are applied before
Visuals after changes are applied after

Copy link

github-actions bot commented Feb 6, 2025

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b gmgonzal-update-project-profile-remove-jane-he-7652 gh-pages
git pull https://github.com/gmgonzal/website.git update-project-profile-remove-jane-he-7652

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) time sensitive Needs to be worked on by a particular timeframe size: 0.25pt Can be done in 0.5 to 1.5 hours labels Feb 6, 2025
@phunguyen1195 phunguyen1195 self-requested a review February 7, 2025 01:13
@phunguyen1195
Copy link
Member

Review ETA: EOD 2/9/25
Availability: W & F

@Kle012 Kle012 self-requested a review February 8, 2025 02:15
@Kle012
Copy link
Member

Kle012 commented Feb 8, 2025

Review ETA: EOD 2/8/25
Availability: Tuesday & Wednesday

Copy link
Member

@Kle012 Kle012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Great job!

  • PR is made with the correct branch
  • Correct issue is linked
  • Correct member has been removed
  • The change displayed correctly on broswer
  • No additional issues
  • CodeQL alerts checked

Thank you.

@katiejnete
Copy link
Member

Review ETA: EOD 2/7/25
Availability: 6-9PM 2/7/25

Copy link
Member

@katiejnete katiejnete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gmgonzal , thank you for taking on this issue.

Things you did well:

  • PR is done with the correct branch.
  • PR contains correctly formatted linked issue.
  • CodeQL Alerts have been properly checked.
  • Before and after screenshots are appropriately included.
  • PR follows correct format and is properly written.
  • The changes are applicable to the issue.
  • Website is still user-friendly and links and components still work as intended.
  • Source code changes are applicable and clean.

Suggested changes:

  • None

Thank you for your hard work @gmgonzal , I approve this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours time sensitive Needs to be worked on by a particular timeframe
Projects
Status: PRs ✅ waiting for merge team
Development

Successfully merging this pull request may close these issues.

Update Project Profile: LA TDM Calculator Remove Jane He
4 participants