Skip to content

Updated wins.js so Wins page uses icon-github.svg #8379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 28, 2025
Merged

Updated wins.js so Wins page uses icon-github.svg #8379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2f6b63d
Replaced the current github icon used within wins card template to th…
santi-jose Oct 15, 2025
86a2bb4
Removed the line of code which set the srouce of the github icon div …
santi-jose Oct 15, 2025
db760ed
Added styling for github-icon class and the nested svg to match the a…
santi-jose Oct 21, 2025
93cf472
Merge branch 'gh-pages' into update-wins_js-to-use-icon-github_svg-6911
santi-jose Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion _includes/wins-page/wins-card-template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,11 @@
<span class="wins-card-name"> </span>
<span class="wins-card-icons">
<a target="_blank" class="wins-card-linkedin-icon"><img class="linkedin-icon" alt="" /></a>
<a target="_blank" class="wins-card-github-icon"><img class="github-icon" alt="" /></a>
<a target="_blank" class="wins-card-github-icon" style="color:black">
<div role="img" class="github-icon">
{% include svg/icon-github.svg %}
</div>
</a>
</span>
</div>
<div class="project-inner wins-card-team"></div>
Expand Down
11 changes: 11 additions & 0 deletions _sass/components/_wins-page.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,6 +280,17 @@
display: flex;
}

.github-icon{
width: 32px;
height: 32px;
max-width: 100%;
}

.github-icon svg{
width: 100%;
height: 100%;
}

@media #{$bp-below-desktop} {
.wins-card {
position: relative;
Expand Down
4 changes: 1 addition & 3 deletions assets/js/wins.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,6 @@
const cardTemplate = document.getElementById("wins-card-template");
const QUOTE_ICON_PATH = '/assets/images/wins-page/quote-icon.svg'
const AVATAR_DEFAULT_PATH = "/assets/images/wins-page/avatar-default.svg"
const GITHUB_ICON = '/assets/images/wins-page/icon-github-small.svg';
const LINKEDIN_ICON = '/assets/images/wins-page/icon-linkedin-small.svg'
const winsCardContainer = document.querySelector('#responses');

Expand Down Expand Up @@ -330,8 +329,7 @@

if (card[github_url].length > 0){
cloneCardTemplate.querySelector('.wins-card-github-icon').href = card[github_url];
cloneCardTemplate.querySelector('.github-icon').src = GITHUB_ICON ;
cloneCardTemplate.querySelector('.github-icon').alt = `GitHub profile for ${card[name]}`;
cloneCardTemplate.querySelector('.github-icon').setAttribute('aria-label' ,`GitHub profile for ${card[name]}`);
} else {
cloneCardTemplate.querySelector('.wins-card-github-icon').setAttribute('hidden', 'true')
}
Expand Down