Create Give Page #220
Create Give Page #220
Conversation
Probably gonna find logos for each of these and a blurb from each...
|
Thanks. We;ll probably adjust the copy on the HG Labs page, but what we have is fine for now. I'll ping the other folks involved for feedback on the text snippets as they relate to their orgs. |
|
If that creates an unnecessary bottleneck, I can just remove that and adding blurbs can become a smaller PR. |
|
The page looks oustanding! I think this will make for a solid platform to build off of moving forward. Thank you so much for putting this together!
|
To @zach2825's point, this is highly specific to the Give page, so better to nest this.
This uses Blade components and moves the new row/column styles into the primary sheet so they can be used elsewhere. Added a note for what can be done later when a wider selection of max columns per row is necessary.
There was a problem hiding this comment.
Had to find this again. But with this syntax, Blade components can automatically accept classes from the outer markup, like in give.blade.php where you'll find these lines:
<x-flex-row class="w-100">In these cases, the default and external classes will combine.
(edit: realizing late that it might've made more sense to attach this to the other component template...)
| margin-top: calc(var(--gap) / 4); | ||
| } | ||
|
|
||
| @at-root { |
There was a problem hiding this comment.
This will allow the default .flex-row-column styles to apply only to the column while also applying the width calculation as it relates to the parent row selector.
I also forgot to account for mobile devices previously, but this is at least a bit friendlier to them.
|
@JSn1nj4 no rush, but I figured to check in and see if we're feeling comfortable, or close to comfortable, about the state of this PR after the comments from Matt, Bogdan, and Zach. It doesn't seem the organizers of the initiatives had much feedback on changing the existing text, so we can go live and always change the verbiage later once it's live people feel more compelled to share their feedback. |
|
I think it's good to go. |
|
@JSn1nj4 I see we have some default HTML title and meta descriptions in resources/views/give.blade.php Let's update those to Meta Description |
|
@allella those are updated. I also brought back the summary paragraph that I originally had commented out on the page as a placeholder. Figured the meta description would make a good page summary. Does that sound alright? |
I'm not sure how everyone feels about grabbing text snippets from the third-party sites to fill the gaps a bit, but I wanted to do it at least for this screenshot.
It's the ones outlined in red:
If something like that is iffy, I'll go ahead and remove those blurbs for now.
Closes #161