chore: remarks

hackolade · Dec 26, 2024 · aae8bf6 · aae8bf6
1 parent 190fcd6
commit aae8bf6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 11 deletions.
diff --git a/forward_engineering/services/statements/indexesStatements.js b/forward_engineering/services/statements/indexesStatements.js
@@ -155,7 +155,7 @@ const getWithClause = index => {
 		: '';
 
 	const nodeStatement = joinStatements({
-		statements: index.withOptions.nodes.map(node => `"${node.nodeName}"`),
+		statements: index.withOptions?.nodes?.map(node => `"${node.nodeName}"`),
 		separator: ',',
 	});
 	const nodes = get(index, 'withOptions.nodes', []).length ? `"nodes":[${nodeStatement}]` : '';

diff --git a/reverse_engineering/helpers/indexHelper.js b/reverse_engineering/helpers/indexHelper.js
@@ -10,15 +10,7 @@ const handleIndex = index => {
 	return pickBy(indexData, value => !isUndefined(value));
 };
 
-const getIndexExpression = ({ index }) => {
-	if (index.index_key) {
-		return index.index_key.map(getExpression).join(',');
-	}
-};
-
 const getHackoladeCompatibleIndex = index => {
-	const indexExpression = getIndexExpression({ index });
-
 	if (index.is_primary) {
 		return {
 			indxName: index.name,
@@ -30,14 +22,14 @@ const getHackoladeCompatibleIndex = index => {
 			indxName: index.name,
 			indxType: INDEX_TYPE.array,
 			usingGSI: index.using === 'gsi',
-			arrayExpr: indexExpression,
+			arrayExpr: index.index_key.map(getExpression).join(','),
 			whereClause: getWhereCondition(index),
 		};
 	} else if (checkMetaIndex(index)) {
 		return {
 			indxName: index.name,
 			indxType: INDEX_TYPE.metadata,
-			metadataExpr: indexExpression,
+			metadataExpr: index.index_key.map(getExpression).join(','),
 		};
 	} else {
 		const partitionByHash = getPartition(index);