Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link State 2018 Update #134

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Link State 2018 Update #134

wants to merge 1 commit into from

Conversation

ramon349
Copy link
Member

@ramon349 ramon349 commented Sep 7, 2018

  1. updated exec to reflect current election
  2. applied relevant changes to demonstrate linkstate 2018

2. applied relevant changes to demonstrate linkstate 2018w
Copy link
Member

@thomasrussellmurphy thomasrussellmurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nonbinding comments provided for @ramon349. So long as everything renders, this should be Good Enough to start changes. Comments are about mostly minor changes.

app/views/acm/conference/2018.haml Show resolved Hide resolved
#{meta_tag "@cwruacm", :name => "twitter:site"}
#{meta_tag "EECS @ CWRU -- Link-State 2018 Conference", :name => "twitter:title"}
#{meta_tag "The fifth annual student-run tech conference at Case Western Reserve University taking place all day on Saturday October 7th, 2018.", :name => "twitter:description"}
#{meta_tag "http://acm.case.edu" + "#{image_path 'LinkState175px.png'}", :name => "twitter:image"}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the desired/up-to-date logo desired in the Twitter Card?

app/views/acm/conference/2018.haml Show resolved Hide resolved
app/views/acm/conference/2018.haml Show resolved Hide resolved
Garage. We are currently working on obtaining parking vouchers.

#register
%h2 Register
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would probably be good to have this be "tickets coming soon" and then replace with the latest EventBrite frame later.

@@ -53,17 +53,6 @@
* [View conference archives](#{url_for('acm/conference/about')}#archive)
* [Get details about the next Link-State conference](#{url_for('acm/conference')})

%h2#hackathon
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth leaving a link as a "related event"?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps. I removed it since hackcwru is it's own seperate organization now.

@@ -0,0 +1,167 @@
#{meta_tag "summary", :name => "twitter:card"}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File comment: have you tested that it renders in a local instance?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you asking if the twitter link works. Or is there something else we're suppose to load?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants