-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tool to convert between atom names conventions #114
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Did not check though against the HADDOCK topologies. The file containing all amino acids topologies in HADDOCK is in the toppar
directory and called: protein-allhdg5-4.top
I am checking and they are the same as Another important change is:
|
Equal to XPLOR but with OXT at the end.
I think this is it. tests okay in py27 and py38. @JoaoRodrigues have your say. |
A user from the forum is requesting this tool -> https://ask.bioexcel.eu/t/prodigy-fails-to-calculate-binding-energy-of-protein-protein-complex/3420/3 I think is it's a useful tool and we should merge it soon. |
I'm gonna go ahead and close this since we discussed online that this falls a little out of the scope of the tools and requires a lot of maintenance (all the conversion schemes, etc need to be maintained). |
Follows discussion on #113
For now, adds two conversion tables between:
The input
pdb
atom name format is guessed on the fly, hence there is a bit of computation penalty.TODO:
implement XPLORN-terminal Hs, also PROhistidinesOT1
like atoms.What are your thoughts?
Still, I think #113 is a valuable tool.