Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tool to convert between atom names conventions #114

Closed
wants to merge 22 commits into from

Conversation

joaomcteixeira
Copy link
Member

@joaomcteixeira joaomcteixeira commented Nov 8, 2021

Follows discussion on #113

For now, adds two conversion tables between:

  • BMRB/PDBv3/Amber
  • Old PDB

The input pdb atom name format is guessed on the fly, hence there is a bit of computation penalty.

TODO:

  • implement XPLOR
  • tests
  • improve docs
  • N-terminal Hs, also PRO
  • histidines
  • make trick to implement OT1 like atoms.

What are your thoughts?

Still, I think #113 is a valuable tool.

Copy link
Member

@amjjbonvin amjjbonvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Did not check though against the HADDOCK topologies. The file containing all amino acids topologies in HADDOCK is in the toppar directory and called: protein-allhdg5-4.top

@joaomcteixeira
Copy link
Member Author

I am checking and they are the same as xplor. One difference is that xplor (according to here) has HB2/HB1 swapped with 1HB/2HB with the other nomenclatures. Did you know anything about this for CNS?

Another important change is:

! CNS v1.3 (27-Feb-10): changed OT1, OT2 to O, OXT, respectively. xplor keeps OT1 and OT2.

@joaomcteixeira
Copy link
Member Author

I think this is it. tests okay in py27 and py38. @JoaoRodrigues have your say.

@joaomcteixeira joaomcteixeira marked this pull request as ready for review November 11, 2021 11:12
@joaomcteixeira
Copy link
Member Author

A user from the forum is requesting this tool -> https://ask.bioexcel.eu/t/prodigy-fails-to-calculate-binding-energy-of-protein-protein-complex/3420/3

I think is it's a useful tool and we should merge it soon.

@joaomcteixeira joaomcteixeira marked this pull request as draft February 1, 2022 22:38
@JoaoRodrigues
Copy link
Member

I'm gonna go ahead and close this since we discussed online that this falls a little out of the scope of the tools and requires a lot of maintenance (all the conversion schemes, etc need to be maintained).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants