generated from obsidianmd/obsidian-sample-plugin
-
-
Notifications
You must be signed in to change notification settings - Fork 82
Fix/amazon scraper #317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Fix/amazon scraper #317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removing pre-commit hook
…rmatting Render Kindle metadata in multiline YAML
Fix Amazon.com web scraper by updating selectors
This commit addresses two issues: 1. A `TypeError: (0 , o.default) is not a function` error that occurred during the Amazon sync process. The error was caused by an incorrect ES6 default import of the `fletcher` library, which is a CommonJS module. The import has been changed to use `import = require()` syntax in `src/utils/hash.ts`, and the corresponding type definition in `src/custom.d.ts` has been updated to use `export =`. 2. A webpack warning `export 'default' (reexported as 'scrapeBooks') was not found in './scrapeBooks'`. This was caused by the `scrapeBooks` function not being exported from `src/scraper/scrapeBooks.ts` and being imported as a default module in `src/scraper/index.ts`. The function is now correctly exported and imported as a named module.
Fix TypeError during sync and resolve webpack warning
Author
|
Sorry, this PR was sent in error - disregard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.